Bug 124174

Summary: Remove unused Qt cruft
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: New BugsAssignee: Anders Carlsson <andersca>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, gyuyoung.kim, ossy, thorton
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 124182, 124187    
Bug Blocks:    
Attachments:
Description Flags
Patch none

Anders Carlsson
Reported 2013-11-11 17:02:00 PST
Remove unused Qt cruft
Attachments
Patch (2.90 KB, patch)
2013-11-11 17:10 PST, Anders Carlsson 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2013-11-11 17:10:27 PST
Created attachment 216625 [details] Patch
Anders Carlsson
Comment 2 2013-11-11 17:15:32 PST
Committed r159088: <http://trac.webkit.org/changeset/159088>
Csaba Osztrogonác
Comment 3 2013-11-11 22:01:24 PST
(In reply to comment #2) > Committed r159088: <http://trac.webkit.org/changeset/159088> It seems it isn't Qt and isn't cruft, because it broke the EFL build: /mnt/buildbot/efl-linux-slave-3/efl-linux-32-release/build/Source/WebKit2/UIProcess/CoordinatedGraphics/WebView.cpp: In member function 'virtual void WebKit::WebView::processDidCrash()': /mnt/buildbot/efl-linux-slave-3/efl-linux-32-release/build/Source/WebKit2/UIProcess/CoordinatedGraphics/WebView.cpp:354:46: error: 'class WebKit::WebPageProxy' has no member named 'urlAtProcessExit'
Csaba Osztrogonác
Comment 4 2013-11-11 22:07:47 PST
Do you think if we can revert this change or should EFL drop the code display a warning which page the WebProcess crashed on?
Gyuyoung Kim
Comment 5 2013-11-11 22:19:17 PST
(In reply to comment #4) > Do you think if we can revert this change or should EFL drop > the code display a warning which page the WebProcess crashed on? Ryuan file a Bug 124182 to drop to report a url which page came to crash. But, it seems to me that it is more helpful to report crashed url. Anders, could you let me know why urlAtProcessExit() is cruft ? Because GTK port has a build break as well.
WebKit Commit Bot
Comment 6 2013-11-11 22:35:31 PST
Re-opened since this is blocked by bug 124187
Csaba Osztrogonác
Comment 7 2013-11-12 00:12:10 PST
Leave it open until we get the answer if removing this code was only a mistake or intentional.
Note You need to log in before you can comment on or make changes to this bug.