Bug 124165

Summary:

Remote Layer Tree: Implement Page Overlays

Product:

WebKit

Reporter:

Tim Horton <thorton>

Component:

WebKit2

Assignee:

Tim Horton <thorton>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

andersca, sam, simon.fraser

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
patch	none
anders comments	andersca: review+
for landing once SVN returns	none

Tim Horton

Reported 2013-11-11 13:58:17 PST

Bring over page overlay functionality from TCADA. <rdar://problem/15199056>

Attachments
patch (11.79 KB, patch) 2013-11-11 15:42 PST, Tim Horton	no flags	Details Formatted Diff Diff
anders comments (11.73 KB, patch) 2013-11-11 15:53 PST, Tim Horton	andersca: review+	Details Formatted Diff Diff
for landing once SVN returns (11.36 KB, patch) 2013-11-11 16:11 PST, Tim Horton	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Tim Horton

Comment 1 2013-11-11 15:42:04 PST

Created attachment 216616 [details] patch

Tim Horton

Comment 2 2013-11-11 15:53:02 PST

Created attachment 216617 [details] anders comments

Anders Carlsson

Comment 3 2013-11-11 16:00:30 PST

Comment on attachment 216617 [details] anders comments View in context: https://bugs.webkit.org/attachment.cgi?id=216617&action=review > Source/WebKit2/WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.h:78 > + typedef HashMap<PageOverlay*, std::unique_ptr<GraphicsLayerCARemote>> PageOverlayLayerMap; > + PageOverlayLayerMap m_pageOverlayLayers; No need for a typedef here.

Tim Horton

Comment 4 2013-11-11 16:11:12 PST

Created attachment 216620 [details] for landing once SVN returns

Tim Horton

Comment 5 2013-11-11 16:23:20 PST

http://trac.webkit.org/changeset/159079

Note You need to log in before you can comment on or make changes to this bug.