Bug 124152

Summary: Fix undefined reference issues in JavaScriptCore build.
Product: WebKit Reporter: Balazs Kilvady <kilvadyb>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, fpizlo, fu, gergely, ggaren, gtk-ews, jbriance, msaboff, oliver, palfia, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed patch.
oliver: review+, gtk-ews: commit-queue-
fixed patch. none

Description Balazs Kilvady 2013-11-11 09:21:42 PST 
These errors come up when building GTK port of jsc with gcc 4.7.2.
Linking CXX executable ../../../bin/jsc
../../../lib/libjavascriptcoregtk.a(SymbolTable.cpp.o): In function `JSC::SharedSymbolTable::destroy(JSC::JSCell*)':
SymbolTable.cpp:(.text._ZN3JSC17SharedSymbolTable7destroyEPNS_6JSCellE+0x44): undefined reference to `JSC::JSCell::inherits(JSC::ClassInfo const*) const'

../../../lib/libjavascriptcoregtk.a(SymbolTable.cpp.o): In function `JSC::SharedSymbolTable::destroy(JSC::JSCell*)':
SymbolTable.cpp:(.text._ZN3JSC17SharedSymbolTable7destroyEPNS_6JSCellE+0x44): undefined reference to `JSC::JSCell::classInfo() const'
Comment 1 Balazs Kilvady 2013-11-11 09:30:23 PST 
Created attachment 216580 [details]
proposed patch.
Comment 2 kov's GTK+ EWS bot 2013-11-11 09:47:44 PST 
Comment on attachment 216580 [details]
proposed patch.

Attachment 216580 [details] did not pass gtk-ews (gtk):
Output: http://webkit-queues.appspot.com/results/22938190
Comment 3 Zan Dobersek 2013-11-11 14:55:15 PST 
Comment on attachment 216580 [details]
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=216580&action=review

> Source/JavaScriptCore/runtime/SymbolTable.cpp:33
> +#include "JSCellInlines.h"
> +#include "JSDestructibleObject.h"

Additionally include the SlotVisitorInlines.h header to get rid of the new undefined reference that was exposed by the GTK EWS.

I think after that the patch will be good to go into the tree.
Comment 4 Balazs Kilvady 2013-11-12 01:06:17 PST 
Created attachment 216649 [details]
fixed patch.

SlotVisitorInlines.h added, thanks to Zan Dobersek. Rebased on 159100.
Comment 5 WebKit Commit Bot 2013-11-12 09:36:00 PST 
Comment on attachment 216649 [details]
fixed patch.

Clearing flags on attachment: 216649

Committed r159116: <http://trac.webkit.org/changeset/159116>
Comment 6 WebKit Commit Bot 2013-11-12 09:36:03 PST 
All reviewed patches have been landed.  Closing bug.