Bug 124150

Summary:

Rename PlatformCertificateInfo to CertificateInfo

Product:

WebKit

Reporter:

Csaba Osztrogonác <ossy>

Component:

New Bugs

Assignee:

Csaba Osztrogonác <ossy>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

andersca, buildbot, cdumez, cgarcia, commit-queue, darin, dino, gustavo, gyuyoung.kim, kling, mrobinson, ossy, rakuco, rniwa, sam

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

118520, 124724, 124720

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none

Csaba Osztrogonác

Reported 2013-11-11 08:44:55 PST

Because Anders asked it in https://bugs.webkit.org/show_bug.cgi?id=118520#c37 and we want to separete renaming and moving thing.

Attachments
Patch (73.95 KB, patch) 2013-11-11 08:56 PST, Csaba Osztrogonác	no flags	Details Formatted Diff Diff
Patch (73.95 KB, patch) 2013-11-11 09:30 PST, Csaba Osztrogonác	no flags	Details Formatted Diff Diff
Patch (73.92 KB, patch) 2013-11-19 07:10 PST, Csaba Osztrogonác	no flags	Details Formatted Diff Diff
Patch (73.90 KB, patch) 2013-11-21 08:07 PST, Csaba Osztrogonác	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Csaba Osztrogonác

Comment 1 2013-11-11 08:56:18 PST

Created attachment 216576 [details] Patch WIP patch for EWS bots.

WebKit Commit Bot

Comment 2 2013-11-11 08:58:14 PST

Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API

WebKit Commit Bot

Comment 3 2013-11-11 08:58:26 PST

Attachment 216576 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/GNUmakefile.list.am', u'Source/WebKit2/NetworkProcess/AsynchronousNetworkLoaderClient.cpp', u'Source/WebKit2/NetworkProcess/NetworkProcess.h', u'Source/WebKit2/NetworkProcess/NetworkProcess.messages.in', u'Source/WebKit2/NetworkProcess/NetworkResourceLoader.cpp', u'Source/WebKit2/NetworkProcess/mac/NetworkProcessMac.mm', u'Source/WebKit2/NetworkProcess/soup/NetworkProcessSoup.cpp', u'Source/WebKit2/PlatformEfl.cmake', u'Source/WebKit2/PlatformGTK.cmake', u'Source/WebKit2/Shared/API/c/mac/WKCertificateInfoMac.mm', u'Source/WebKit2/Shared/Authentication/AuthenticationManager.cpp', u'Source/WebKit2/Shared/Authentication/AuthenticationManager.h', u'Source/WebKit2/Shared/Authentication/AuthenticationManager.messages.in', u'Source/WebKit2/Shared/Authentication/mac/AuthenticationManager.mac.mm', u'Source/WebKit2/Shared/UserMessageCoders.h', u'Source/WebKit2/Shared/WebCertificateInfo.h', u'Source/WebKit2/Shared/mac/CertificateInfo.h', u'Source/WebKit2/Shared/mac/CertificateInfo.mm', u'Source/WebKit2/Shared/mac/PlatformCertificateInfo.h', u'Source/WebKit2/Shared/mac/PlatformCertificateInfo.mm', u'Source/WebKit2/Shared/mac/WebCoreArgumentCodersMac.mm', u'Source/WebKit2/Shared/soup/CertificateInfo.cpp', u'Source/WebKit2/Shared/soup/CertificateInfo.h', u'Source/WebKit2/Shared/soup/PlatformCertificateInfo.cpp', u'Source/WebKit2/Shared/soup/PlatformCertificateInfo.h', u'Source/WebKit2/Shared/soup/WebCoreArgumentCodersSoup.cpp', u'Source/WebKit2/UIProcess/API/gtk/WebKitCertificateInfo.cpp', u'Source/WebKit2/UIProcess/API/gtk/WebKitCertificateInfoPrivate.h', u'Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp', u'Source/WebKit2/UIProcess/Authentication/AuthenticationChallengeProxy.cpp', u'Source/WebKit2/UIProcess/WebContext.cpp', u'Source/WebKit2/UIProcess/WebFrameProxy.cpp', u'Source/WebKit2/UIProcess/WebFrameProxy.h', u'Source/WebKit2/UIProcess/WebPageProxy.cpp', u'Source/WebKit2/UIProcess/WebPageProxy.h', u'Source/WebKit2/UIProcess/WebPageProxy.messages.in', u'Source/WebKit2/WebKit2.xcodeproj/project.pbxproj', u'Source/WebKit2/WebProcess/Network/WebResourceLoader.cpp', u'Source/WebKit2/WebProcess/Network/WebResourceLoader.h', u'Source/WebKit2/WebProcess/Network/WebResourceLoader.messages.in', u'Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp', u'Source/WebKit2/WebProcess/WebProcess.h', u'Source/WebKit2/WebProcess/WebProcess.messages.in', u'Source/WebKit2/WebProcess/soup/WebProcessSoup.cpp']" exit_code: 1 Source/WebKit2/Shared/soup/CertificateInfo.cpp:106: Use 0 instead of NULL. [readability/null] [5] Source/WebKit2/Shared/soup/CertificateInfo.cpp:106: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 2 in 41 files If any of these errors are false positives, please file a bug against check-webkit-style.

Csaba Osztrogonác

Comment 4 2013-11-11 09:03:58 PST

> Source/WebKit2/Shared/soup/CertificateInfo.cpp:106: Use 0 instead of NULL. [readability/null] [5] > Source/WebKit2/Shared/soup/CertificateInfo.cpp:106: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] > Total errors found: 2 in 41 files I didn't touch this code, but NULL is necessary here, we can't use 0.

Build Bot

Comment 5 2013-11-11 09:27:53 PST

Comment on attachment 216576 [details] Patch Attachment 216576 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/22938181

Csaba Osztrogonác

Comment 6 2013-11-11 09:30:11 PST

Created attachment 216579 [details] Patch with speculative Mac fix

WebKit Commit Bot

Comment 7 2013-11-11 09:33:37 PST

Attachment 216579 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/GNUmakefile.list.am', u'Source/WebKit2/NetworkProcess/AsynchronousNetworkLoaderClient.cpp', u'Source/WebKit2/NetworkProcess/NetworkProcess.h', u'Source/WebKit2/NetworkProcess/NetworkProcess.messages.in', u'Source/WebKit2/NetworkProcess/NetworkResourceLoader.cpp', u'Source/WebKit2/NetworkProcess/mac/NetworkProcessMac.mm', u'Source/WebKit2/NetworkProcess/soup/NetworkProcessSoup.cpp', u'Source/WebKit2/PlatformEfl.cmake', u'Source/WebKit2/PlatformGTK.cmake', u'Source/WebKit2/Shared/API/c/mac/WKCertificateInfoMac.mm', u'Source/WebKit2/Shared/Authentication/AuthenticationManager.cpp', u'Source/WebKit2/Shared/Authentication/AuthenticationManager.h', u'Source/WebKit2/Shared/Authentication/AuthenticationManager.messages.in', u'Source/WebKit2/Shared/Authentication/mac/AuthenticationManager.mac.mm', u'Source/WebKit2/Shared/UserMessageCoders.h', u'Source/WebKit2/Shared/WebCertificateInfo.h', u'Source/WebKit2/Shared/mac/CertificateInfo.h', u'Source/WebKit2/Shared/mac/CertificateInfo.mm', u'Source/WebKit2/Shared/mac/PlatformCertificateInfo.h', u'Source/WebKit2/Shared/mac/PlatformCertificateInfo.mm', u'Source/WebKit2/Shared/mac/WebCoreArgumentCodersMac.mm', u'Source/WebKit2/Shared/soup/CertificateInfo.cpp', u'Source/WebKit2/Shared/soup/CertificateInfo.h', u'Source/WebKit2/Shared/soup/PlatformCertificateInfo.cpp', u'Source/WebKit2/Shared/soup/PlatformCertificateInfo.h', u'Source/WebKit2/Shared/soup/WebCoreArgumentCodersSoup.cpp', u'Source/WebKit2/UIProcess/API/gtk/WebKitCertificateInfo.cpp', u'Source/WebKit2/UIProcess/API/gtk/WebKitCertificateInfoPrivate.h', u'Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp', u'Source/WebKit2/UIProcess/Authentication/AuthenticationChallengeProxy.cpp', u'Source/WebKit2/UIProcess/WebContext.cpp', u'Source/WebKit2/UIProcess/WebFrameProxy.cpp', u'Source/WebKit2/UIProcess/WebFrameProxy.h', u'Source/WebKit2/UIProcess/WebPageProxy.cpp', u'Source/WebKit2/UIProcess/WebPageProxy.h', u'Source/WebKit2/UIProcess/WebPageProxy.messages.in', u'Source/WebKit2/WebKit2.xcodeproj/project.pbxproj', u'Source/WebKit2/WebProcess/Network/WebResourceLoader.cpp', u'Source/WebKit2/WebProcess/Network/WebResourceLoader.h', u'Source/WebKit2/WebProcess/Network/WebResourceLoader.messages.in', u'Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp', u'Source/WebKit2/WebProcess/WebProcess.h', u'Source/WebKit2/WebProcess/WebProcess.messages.in', u'Source/WebKit2/WebProcess/soup/WebProcessSoup.cpp']" exit_code: 1 Source/WebKit2/Shared/soup/CertificateInfo.cpp:106: Use 0 instead of NULL. [readability/null] [5] Source/WebKit2/Shared/soup/CertificateInfo.cpp:106: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 2 in 41 files If any of these errors are false positives, please file a bug against check-webkit-style.

Csaba Osztrogonác

Comment 8 2013-11-11 11:27:14 PST

Is there any objection against this renaming?

Csaba Osztrogonác

Comment 9 2013-11-19 07:10:52 PST

Created attachment 217298 [details] Patch Updated to ToT.

WebKit Commit Bot

Comment 10 2013-11-19 07:13:15 PST

Attachment 217298 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/GNUmakefile.list.am', u'Source/WebKit2/NetworkProcess/AsynchronousNetworkLoaderClient.cpp', u'Source/WebKit2/NetworkProcess/NetworkProcess.h', u'Source/WebKit2/NetworkProcess/NetworkProcess.messages.in', u'Source/WebKit2/NetworkProcess/NetworkResourceLoader.cpp', u'Source/WebKit2/NetworkProcess/mac/NetworkProcessMac.mm', u'Source/WebKit2/NetworkProcess/soup/NetworkProcessSoup.cpp', u'Source/WebKit2/PlatformEfl.cmake', u'Source/WebKit2/PlatformGTK.cmake', u'Source/WebKit2/Shared/API/c/mac/WKCertificateInfoMac.mm', u'Source/WebKit2/Shared/Authentication/AuthenticationManager.cpp', u'Source/WebKit2/Shared/Authentication/AuthenticationManager.h', u'Source/WebKit2/Shared/Authentication/AuthenticationManager.messages.in', u'Source/WebKit2/Shared/Authentication/mac/AuthenticationManager.mac.mm', u'Source/WebKit2/Shared/UserMessageCoders.h', u'Source/WebKit2/Shared/WebCertificateInfo.h', u'Source/WebKit2/Shared/mac/CertificateInfo.h', u'Source/WebKit2/Shared/mac/CertificateInfo.mm', u'Source/WebKit2/Shared/mac/PlatformCertificateInfo.h', u'Source/WebKit2/Shared/mac/PlatformCertificateInfo.mm', u'Source/WebKit2/Shared/mac/WebCoreArgumentCodersMac.mm', u'Source/WebKit2/Shared/soup/CertificateInfo.cpp', u'Source/WebKit2/Shared/soup/CertificateInfo.h', u'Source/WebKit2/Shared/soup/PlatformCertificateInfo.cpp', u'Source/WebKit2/Shared/soup/PlatformCertificateInfo.h', u'Source/WebKit2/Shared/soup/WebCoreArgumentCodersSoup.cpp', u'Source/WebKit2/UIProcess/API/gtk/WebKitCertificateInfo.cpp', u'Source/WebKit2/UIProcess/API/gtk/WebKitCertificateInfoPrivate.h', u'Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp', u'Source/WebKit2/UIProcess/Authentication/AuthenticationChallengeProxy.cpp', u'Source/WebKit2/UIProcess/WebContext.cpp', u'Source/WebKit2/UIProcess/WebFrameProxy.cpp', u'Source/WebKit2/UIProcess/WebFrameProxy.h', u'Source/WebKit2/UIProcess/WebPageProxy.cpp', u'Source/WebKit2/UIProcess/WebPageProxy.h', u'Source/WebKit2/UIProcess/WebPageProxy.messages.in', u'Source/WebKit2/WebKit2.xcodeproj/project.pbxproj', u'Source/WebKit2/WebProcess/Network/WebResourceLoader.cpp', u'Source/WebKit2/WebProcess/Network/WebResourceLoader.h', u'Source/WebKit2/WebProcess/Network/WebResourceLoader.messages.in', u'Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp', u'Source/WebKit2/WebProcess/WebProcess.h', u'Source/WebKit2/WebProcess/WebProcess.messages.in', u'Source/WebKit2/WebProcess/soup/WebProcessSoup.cpp']" exit_code: 1 Source/WebKit2/Shared/soup/CertificateInfo.cpp:106: Use 0 instead of NULL. [readability/null] [5] Source/WebKit2/Shared/soup/CertificateInfo.cpp:106: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 2 in 41 files If any of these errors are false positives, please file a bug against check-webkit-style.

Csaba Osztrogonác

Comment 11 2013-11-19 07:14:36 PST

Please ignore the style alarm, it is still false.

Brent Fulgham

Comment 12 2013-11-19 09:46:46 PST

Comment on attachment 217298 [details] Patch r=me, but please address the two style complaints. I know you are being unfairly tagged for code you are simply renaming, but these are so simple it would be nice to get a full green build.

Carlos Garcia Campos

Comment 13 2013-11-19 09:58:55 PST

(In reply to comment #12) > (From update of attachment 217298 [details]) > r=me, but please address the two style complaints. I know you are being unfairly tagged for code you are simply renaming, but these are so simple it would be nice to get a full green build. Ossy, I think you can fix the NULL being used as sentinel by using nullptr instead, because you can't use 0 in that case.

Csaba Osztrogonác

Comment 14 2013-11-21 08:07:45 PST

Created attachment 217571 [details] Patch Style issues fixed. Brent, thanks for the informal review. Can we get the final review from a WK2 owner?

Csaba Osztrogonác

Comment 15 2013-11-21 08:26:37 PST

Additional info: I tested on Safari and certificates still works.

Csaba Osztrogonác

Comment 16 2013-11-21 14:28:52 PST

Comment on attachment 217571 [details] Patch Clearing flags on attachment: 217571 Committed r159647: <http://trac.webkit.org/changeset/159647>

Csaba Osztrogonác

Comment 17 2013-11-21 14:29:01 PST

All reviewed patches have been landed. Closing bug.

Csaba Osztrogonác

Comment 18 2013-11-22 07:51:06 PST

comment from #webkit IRC: <dino_> Ossy_night: I think http://trac.webkit.org/changeset/159647 has caused a lot of WebSocket failures I think you meant the failures on Mavericks Release WK1 tester: http://build.webkit.org/builders/Apple%20Mavericks%20Release%20WK1%20%28Tests%29/builds/1085 I checked this issue, triggered 2 clean builds on this bot - on 159647 - http://build.webkit.org/builders/Apple%20Mavericks%20Release%20WK1%20%28Tests%29/builds/1097 - on 159646 - http://build.webkit.org/builders/Apple%20Mavericks%20Release%20WK1%20%28Tests%29/builds/1098 And the failures were occured on r159646 too, before my patch. And then I noticed it is a WK1 tester bot an my patch is WK2 only, so it was impossible that I broke this bot.

Note You need to log in before you can comment on or make changes to this bug.