Bug 124140 – Do not shut down ImageDiff server after every diff during the tests.

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Tamas Gergely]

There is a FIXME in image_diff.py: There is no need to shut down the ImageDiff server after every diff.

[Tamas Gergely]

Created attachment 216552 [details]
Do not shut down ImageDiff server after every diff during the tests.

[WebKit Commit Bot]

Comment on attachment 216552 [details]
Do not shut down ImageDiff server after every diff during the tests.

Rejecting attachment 216552 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 216552, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
t.org/repository/webkit/trunk ...
Authentication realm: <http://svn.webkit.org:80> Mac OS Forge
Password for '[e-mail]': 
Authentication realm: <http://svn.webkit.org:80> Mac OS Forge
Username: Use of uninitialized value $username in chomp at /usr/share/git-core/perl/Git/SVN/Prompt.pm line 114.
error: git-svn died of signal 11

Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 139 cwd: /Volumes/Data/EWS/WebKit
Updating OpenSource
Current branch master is up to date.

Full output: http://webkit-queues.appspot.com/results/22938116

[Csaba Osztrogonác]

It seems svn.webkit.org has some issue, I tried and wasn't able to land it manually. I sent a mail to wms and bdash about the problem.

[WebKit Commit Bot]

Comment on attachment 216552 [details]
Do not shut down ImageDiff server after every diff during the tests.

Clearing flags on attachment: 216552

Committed r159051: <http://trac.webkit.org/changeset/159051>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.