Bug 124124

Summary: Reduce the size of RenderBlockFlow by making its rare data inherit from RenderBlockRareData
Product: WebKit Reporter: Sam Weinig <sam>
Component: New BugsAssignee: Sam Weinig <sam>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc, glenn, hyatt, kondapallykalyan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
andersca: review+
another none

Sam Weinig
Reported 2013-11-10 09:57:57 PST
Reduce the size of RenderBlockFlow by making its rare data inherit from RenderBlockRareData
Attachments
Patch (17.91 KB, patch)
2013-11-10 09:59 PST, Sam Weinig 		andersca: review+
DetailsFormatted DiffDiff
another (32.62 KB, patch)
2013-11-10 11:32 PST, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2013-11-10 09:59:04 PST
Created attachment 216527 [details] Patch
Antti Koivisto
Comment 2 2013-11-10 11:27:20 PST
Comment on attachment 216527 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=216527&action=review > Source/WebCore/rendering/RenderBlockFlow.h:96 > - struct RenderBlockFlowRareData { > + struct RenderBlockFlowRareData : public RenderBlockRareData { I think most RenderBlocks are RenderBlockFlows. Just smashing these together might be ok too.
Antti Koivisto
Comment 3 2013-11-10 11:32:51 PST
Created attachment 216530 [details] another
Antti Koivisto
Comment 4 2013-11-10 11:33:20 PST
Comment on attachment 216530 [details] another Uh wrong bug
Sam Weinig
Comment 5 2013-11-10 16:20:31 PST
Committed r159034: <http://trac.webkit.org/changeset/159034>
Andreas Kling
Comment 6 2013-11-10 22:12:48 PST
Comment on attachment 216527 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=216527&action=review >> Source/WebCore/rendering/RenderBlockFlow.h:96 >> + struct RenderBlockFlowRareData : public RenderBlockRareData { > > I think most RenderBlocks are RenderBlockFlows. Just smashing these together might be ok too. Yeh. Then we also don't need to have a vtable for RenderBlockRareData.
Dave Hyatt
Comment 7 2013-11-11 08:56:46 PST
I think there was a better way to do this, since you're paying 4 bytes in RenderBlock when RenderBlock's rare data will almost never be allocated. Could have just made a hash for RenderBlock's rare data. I did this without realizing this patch had landed and now have a bunch of conflicts. :)
Note You need to log in before you can comment on or make changes to this bug.