Bug 124084

Summary: getCueAsHTML() on an empty cue should return a document fragment
Product: WebKit Reporter: Eric Carlson <eric.carlson>
Component: MediaAssignee: Eric Carlson <eric.carlson>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc, glenn, gyuyoung.kim, jer.noble
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Proposed patch none

Eric Carlson
Reported 2013-11-08 16:40:07 PST
A cue with no text should return a valid document fragment
Attachments
Proposed patch (4.34 KB, patch)
2013-11-08 16:47 PST, Eric Carlson 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Eric Carlson
Comment 1 2013-11-08 16:47:26 PST
Created attachment 216463 [details] Proposed patch
Darin Adler
Comment 2 2013-11-08 16:56:37 PST
Comment on attachment 216463 [details] Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=216463&action=review > Source/WebCore/html/track/WebVTTParser.cpp:356 > + if (!text.length()) { Normally we’d use isEmpty here instead.
Eric Carlson
Comment 3 2013-11-08 17:11:48 PST
(In reply to comment #2) > (From update of attachment 216463 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=216463&action=review > > > Source/WebCore/html/track/WebVTTParser.cpp:356 > > + if (!text.length()) { > > Normally we’d use isEmpty here instead. Good point, fixed.
Eric Carlson
Comment 4 2013-11-08 17:12:14 PST
Committed r158979: https://trac.webkit.org/r158979
Note You need to log in before you can comment on or make changes to this bug.