Bug 124068

Summary:

Merge IDBCursorBackendInterface and IDBCursorBackendImpl

Product:

WebKit

Reporter:

Brady Eidson <beidson>

Component:

WebCore Misc.

Assignee:

Brady Eidson <beidson>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

alecflett, commit-queue, gyuyoung.kim, jsbell, rakuco

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch v1	andersca: review+
Updated patch for EWS	commit-queue: commit-queue-

Brady Eidson

Reported 2013-11-08 13:41:57 PST

Merge IDBCursorBackendInterface and IDBCursorBackendImpl No need for the abstraction anymore.

Attachments
Patch v1 (72.14 KB, patch) 2013-11-08 14:10 PST, Brady Eidson	andersca: review+	Details Formatted Diff Diff
Updated patch for EWS (71.18 KB, patch) 2013-11-08 14:28 PST, Brady Eidson	commit-queue: commit-queue-	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Brady Eidson

Comment 1 2013-11-08 14:10:26 PST

Created attachment 216437 [details] Patch v1

Brady Eidson

Comment 2 2013-11-08 14:27:15 PST

Thanks for the review - I'll rebase and run the updated patch by EWS before landing

Brady Eidson

Comment 3 2013-11-08 14:28:23 PST

Created attachment 216440 [details] Updated patch for EWS

WebKit Commit Bot

Comment 4 2013-11-08 14:36:12 PST

Comment on attachment 216440 [details] Updated patch for EWS Rejecting attachment 216440 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 216440, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit ChangeLog entry in Source/WebCore/ChangeLog contains OOPS!. Full output: http://webkit-queues.appspot.com/results/22508620

Brady Eidson

Comment 5 2013-11-08 14:47:05 PST

http://trac.webkit.org/changeset/158959

Brady Eidson

Comment 6 2013-11-08 15:15:10 PST

Windows build fix followup in http://trac.webkit.org/changeset/158961

Note You need to log in before you can comment on or make changes to this bug.