Bug 124046

Summary: [WebGL] Removing unnecessary pointer checks
Product: WebKit Reporter: Przemyslaw Szymanski <p.szymanski3>
Component: WebGLAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, dino, esprehn+autocc, gyuyoung.kim, kondapallykalyan, roger_fong, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
glbuffer bfulgham: review+, bfulgham: commit-queue-

Przemyslaw Szymanski
Reported 2013-11-08 08:04:37 PST
When an array pointer is check with 0 it is not necessary to check it again
Attachments
glbuffer (1.70 KB, patch)
2013-11-08 08:09 PST, Przemyslaw Szymanski 		bfulgham: review+
bfulgham: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Przemyslaw Szymanski
Comment 1 2013-11-08 08:09:26 PST
Created attachment 216399 [details] glbuffer
Brent Fulgham
Comment 2 2013-11-19 17:39:37 PST
Comment on attachment 216399 [details] glbuffer View in context: https://bugs.webkit.org/attachment.cgi?id=216399&action=review True! Thanks for catching this. Can you revise the ChangeLog slightly per my comments? > Source/WebCore/ChangeLog:8 > + Pointer to array member can be check only once. It is not need The log message is a little incorrect. I think it should read: "The array argument does not need to checked for NULL more than once."
Brent Fulgham
Comment 3 2014-01-10 10:12:22 PST
Comment on attachment 216399 [details] glbuffer r=me. I'll correct the change log while landing.
Radar WebKit Bug Importer
Comment 4 2014-01-10 10:16:13 PST
<rdar://problem/15793235>
Brent Fulgham
Comment 5 2014-01-10 10:19:00 PST
Committed r161649: <http://trac.webkit.org/changeset/161649>
Note You need to log in before you can comment on or make changes to this bug.