Bug 124038

Summary: REGRESSION(r158883): all layout-jsc tests crash for ARM_TRADITIONAL architecture
Product: WebKit Reporter: Julien Brianceau <jbriance>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ggaren, mandeep.baines, msaboff, ossy, rgabor, zherczeg
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 108645    
Attachments:
Description Flags
run-layout-jsc results
none
ARM fix after r158883
none
run-layout-jsc results (with patch)
none
ARM fix after r158883 (with the good register for ARM_THUMB2) none

Description Julien Brianceau 2013-11-08 05:08:48 PST
layout-jsc tests results for r158882 + changeset 158915: 492 tests passed, 5 tests failed, 0 tests crashed.
layout-jsc tests results for r158883 + changeset 158915: 0 tests passed, 497 tests failed, 497 tests crashed.
Comment 1 Julien Brianceau 2013-11-08 05:16:23 PST
Created attachment 216375 [details]
run-layout-jsc results

Results of revision 158916 of run-layout-jsc run on ARM_TRADITIONAL with:
- r158883 + changeset 158915
- r158883 + changeset 158915
Comment 2 Julien Brianceau 2013-11-08 05:52:32 PST
Created attachment 216381 [details]
ARM fix after r158883
Comment 3 Julien Brianceau 2013-11-08 05:55:09 PST
Created attachment 216382 [details]
run-layout-jsc results (with patch)

With patch tested on r158916:
492 tests passed, 5 tests failed, 0 tests crashed.
Comment 4 Julien Brianceau 2013-11-08 06:09:06 PST
Comment on attachment 216381 [details]
ARM fix after r158883

Oops, there's a mistake, I'll submit a new patch soon
Comment 5 Julien Brianceau 2013-11-08 06:23:23 PST
Created attachment 216386 [details]
ARM fix after r158883 (with the good register for ARM_THUMB2)

Same patch with the correct frame pointer register in getHostCallReturnValue for ARM_THUMB2.
Comment 6 WebKit Commit Bot 2013-11-08 10:23:54 PST
Comment on attachment 216386 [details]
ARM fix after r158883 (with the good register for ARM_THUMB2)

Clearing flags on attachment: 216386

Committed r158926: <http://trac.webkit.org/changeset/158926>
Comment 7 WebKit Commit Bot 2013-11-08 10:23:56 PST
All reviewed patches have been landed.  Closing bug.