Bug 124018

Summary:

Enhance SQL journal_mode setting code to be less likely to log an error

Product:

WebKit

Reporter:

Brady Eidson <beidson>

Component:

WebCore Misc.

Assignee:

Brady Eidson <beidson>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch v1	none

Brady Eidson

Reported 2013-11-07 15:42:01 PST

Enhance SQL journal_mode setting code to be less likely to log an error Even though the docs says SQLITE_ROW will always be returned, apparently SQLITE_OK is sometimes returned. Change the code to handle that.

Attachments
Patch v1 (2.04 KB, patch) 2013-11-07 15:44 PST, Brady Eidson	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Brady Eidson

Comment 1 2013-11-07 15:43:47 PST

In radar as <rdar://problem/15418577>

Brady Eidson

Comment 2 2013-11-07 15:44:07 PST

Created attachment 216339 [details] Patch v1

WebKit Commit Bot

Comment 3 2013-11-07 22:06:45 PST

Comment on attachment 216339 [details] Patch v1 Clearing flags on attachment: 216339 Committed r158906: <http://trac.webkit.org/changeset/158906>

WebKit Commit Bot

Comment 4 2013-11-07 22:06:47 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.