Summary: | Region based multicol: support explicit column breaks | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Morten Stenshorne <mstensho> | ||||||||||||
Component: | Layout and Rendering | Assignee: | Morten Stenshorne <mstensho> | ||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||
Severity: | Normal | CC: | buildbot, commit-queue, esprehn+autocc, glenn, kondapallykalyan, rniwa, WebkitBugTracker | ||||||||||||
Priority: | P2 | ||||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||||
Hardware: | Unspecified | ||||||||||||||
OS: | Unspecified | ||||||||||||||
Attachments: |
|
Description
Morten Stenshorne
2013-11-07 07:44:51 PST
Created attachment 216302 [details]
Test case
Created attachment 221122 [details]
Patch
Comment on attachment 221122 [details] Patch Attachment 221122 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/6094733210288128 Created attachment 221126 [details]
Patch
Comment on attachment 221126 [details]
Patch
r=me
Comment on attachment 221126 [details] Patch Rejecting attachment 221126 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 221126, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: html patching file LayoutTests/fast/multicol/newmulticol/breaks-3-columns-3-expected.html patching file LayoutTests/fast/multicol/newmulticol/breaks-3-columns-3.html patching file LayoutTests/fast/multicol/newmulticol/fixed-height-fill-balance-2-expected.html patching file LayoutTests/fast/multicol/newmulticol/fixed-height-fill-balance-2.html Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'David Hyatt']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.appspot.com/results/6444814115536896 Created attachment 221630 [details]
Patch
Created attachment 221632 [details]
Patch
Comment on attachment 221632 [details]
Patch
r=me
Comment on attachment 221632 [details] Patch Clearing flags on attachment: 221632 Committed r162366: <http://trac.webkit.org/changeset/162366> All reviewed patches have been landed. Closing bug. |