Bug 123993

Summary:

Region based multicol: support explicit column breaks

Product:

WebKit

Reporter:

Morten Stenshorne <mstensho>

Component:

Layout and Rendering

Assignee:

Morten Stenshorne <mstensho>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

buildbot, commit-queue, esprehn+autocc, glenn, kondapallykalyan, rniwa, WebkitBugTracker

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Test case	none
Patch	none
Patch	none
Patch	none
Patch	none

Morten Stenshorne

Reported 2013-11-07 07:44:51 PST

Explicit column breaks are currently not supported in the region based multicol implementation. Apart from simply making the implementation support it at all (which is trivial), we also have to make the column balancer aware of explicit breaks, which is a bit more work.

Attachments
Test case (1.21 KB, text/html) 2013-11-07 07:58 PST, Morten Stenshorne	no flags	Details
Patch (47.28 KB, patch) 2014-01-14 01:28 PST, Morten Stenshorne	no flags	Details Formatted Diff Diff
Patch (47.28 KB, patch) 2014-01-14 01:48 PST, Morten Stenshorne	no flags	Details Formatted Diff Diff
Patch (47.31 KB, patch) 2014-01-20 00:59 PST, Morten Stenshorne	no flags	Details Formatted Diff Diff
Patch (47.31 KB, patch) 2014-01-20 01:16 PST, Morten Stenshorne	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Morten Stenshorne

Comment 1 2013-11-07 07:58:12 PST

Created attachment 216302 [details] Test case

Morten Stenshorne

Comment 2 2014-01-14 01:28:56 PST

Created attachment 221122 [details] Patch

Build Bot

Comment 3 2014-01-14 01:35:39 PST

Comment on attachment 221122 [details] Patch Attachment 221122 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/6094733210288128

Morten Stenshorne

Comment 4 2014-01-14 01:48:28 PST

Created attachment 221126 [details] Patch

Dave Hyatt

Comment 5 2014-01-17 11:41:14 PST

Comment on attachment 221126 [details] Patch r=me

WebKit Commit Bot

Comment 6 2014-01-20 00:27:36 PST

Comment on attachment 221126 [details] Patch Rejecting attachment 221126 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 221126, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: html patching file LayoutTests/fast/multicol/newmulticol/breaks-3-columns-3-expected.html patching file LayoutTests/fast/multicol/newmulticol/breaks-3-columns-3.html patching file LayoutTests/fast/multicol/newmulticol/fixed-height-fill-balance-2-expected.html patching file LayoutTests/fast/multicol/newmulticol/fixed-height-fill-balance-2.html Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'David Hyatt']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.appspot.com/results/6444814115536896

Morten Stenshorne

Comment 7 2014-01-20 00:59:52 PST

Created attachment 221630 [details] Patch

Morten Stenshorne

Comment 8 2014-01-20 01:16:13 PST

Created attachment 221632 [details] Patch

Dave Hyatt

Comment 9 2014-01-20 11:34:10 PST

Comment on attachment 221632 [details] Patch r=me

WebKit Commit Bot

Comment 10 2014-01-20 11:51:38 PST

Comment on attachment 221632 [details] Patch Clearing flags on attachment: 221632 Committed r162366: <http://trac.webkit.org/changeset/162366>

WebKit Commit Bot

Comment 11 2014-01-20 11:51:41 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.