Bug 123985

Summary:

[EFL] Layout tests with vertical texts need to be rebaselined

Product:

WebKit

Reporter:

Denis Nomiyama (dnomi) <d.nomiyama>

Component:

WebKit EFL

Assignee:

Gyuyoung Kim <gyuyoung.kim>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, d.nomiyama, gyuyoung.kim, lucas.de.marchi, mario

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Denis Nomiyama (dnomi)

Reported 2013-11-07 03:16:25 PST

Once the patch from Bug 50619 lands, some layout tests that uses vertical texts will need to be rebaselined. Here is the list. editing/selection/vertical-lr-ltr-extend-line-backward-br.html editing/selection/vertical-lr-ltr-extend-line-forward-br.html editing/selection/vertical-rl-ltr-extend-line-backward-br.html editing/selection/vertical-rl-ltr-extend-line-backward-p.html editing/selection/vertical-rl-ltr-extend-line-backward-wrap.html editing/selection/vertical-rl-ltr-extend-line-forward-br.html editing/selection/vertical-rl-ltr-extend-line-forward-p.html editing/selection/vertical-rl-ltr-extend-line-forward-wrap.html fast/block/lineboxcontain/block-with-ideographs.xhtml fast/css/relative-positioned-block-with-inline-ancestor-and-parent-dynamic.html fast/dynamic/text-combine.html fast/html/details-writing-mode.html fast/repaint/japanese-rl-selection-clear.html fast/repaint/japanese-rl-selection-repaint-in-regions.html fast/repaint/japanese-rl-selection-repaint.html fast/repaint/repaint-across-writing-mode-boundary.html fast/ruby/base-shorter-than-text.html fast/text/decorations-with-text-combine.html fast/text/emphasis-combined-text.html fast/text/emphasis-vertical.html fast/text/international/text-combine-image-test.html fast/text/international/text-spliced-font.html fast/text/international/vertical-text-glyph-test.html fast/text/justify-ideograph-vertical.html fast/text/orientation-sideways.html fast/writing-mode/Kusa-Makura-background-canvas.html fast/writing-mode/border-vertical-lr.html fast/writing-mode/broken-ideograph-small-caps.html fast/writing-mode/broken-ideographic-font.html fast/writing-mode/fallback-orientation.html fast/writing-mode/japanese-lr-selection.html fast/writing-mode/japanese-lr-text.html fast/writing-mode/japanese-rl-selection.html fast/writing-mode/japanese-rl-text-with-broken-font.html fast/writing-mode/japanese-rl-text.html fast/writing-mode/japanese-ruby-vertical-lr.html fast/writing-mode/japanese-ruby-vertical-rl.html fast/writing-mode/text-orientation-basic.html fast/writing-mode/vertical-align-table-baseline.html fast/writing-mode/vertical-baseline-alignment.html fast/writing-mode/vertical-font-fallback.html

Attachments
Patch (771.62 KB, patch) 2013-11-07 21:16 PST, Gyuyoung Kim	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Mario Sanchez Prada

Comment 1 2013-11-07 07:20:26 PST

(In reply to comment #0) > Once the patch from Bug 50619 lands, some layout tests that uses vertical texts > will need to be rebaselined. > It's done: http://trac.webkit.org/changeset/158848 Let's keep an eye on the bots now and rebaseline EFL expectations as needed (ping Gyuyoung)

Denis Nomiyama (dnomi)

Comment 2 2013-11-07 10:32:01 PST

According to WebKit console, the patch didn’t break the GTK+ port and some tests are now failing on the EFL port as expected. So it is safe to rebaseline the tests on EFL.

Gyuyoung Kim

Comment 3 2013-11-07 21:16:54 PST

Created attachment 216358 [details] Patch

WebKit Commit Bot

Comment 4 2013-11-07 21:50:13 PST

Comment on attachment 216358 [details] Patch Clearing flags on attachment: 216358 Committed r158905: <http://trac.webkit.org/changeset/158905>

WebKit Commit Bot

Comment 5 2013-11-07 21:50:16 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.