Bug 123969

Summary: Build is broken for architectures with 4 argument registers since r158820
Product: WebKit Reporter: Julien Brianceau <jbriance>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, fpizlo, ggaren, mhahnenberg, oliver, ossy, rniwa
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Build fix none

Description Julien Brianceau 2013-11-07 00:34:31 PST
In jit/CCallHelpers:
- void setupArguments(GPRReg arg1, GPRReg arg2, TrustedImmPtr arg3, TrustedImm32 arg4, GPRReg arg5, GPRReg arg6) is missing
- function using GPRInfo::argumentGPR4 must be under #if NUMBER_OF_ARGUMENT_REGISTERS >= 5 condition
Comment 1 Julien Brianceau 2013-11-07 00:40:48 PST
Created attachment 216269 [details]
Build fix

- add void setupArguments(GPRReg arg1, GPRReg arg2, TrustedImmPtr arg3, TrustedImm32 arg4, GPRReg arg5, GPRReg arg6) for architectures having NUMBER_OF_ARGUMENT_REGISTERS == 4 
- move function using GPRInfo::argumentGPR4 under #if NUMBER_OF_ARGUMENT_REGISTERS >= 5 condition
Comment 2 WebKit Commit Bot 2013-11-07 02:00:42 PST
Comment on attachment 216269 [details]
Build fix

Clearing flags on attachment: 216269

Committed r158830: <http://trac.webkit.org/changeset/158830>
Comment 3 WebKit Commit Bot 2013-11-07 02:00:44 PST
All reviewed patches have been landed.  Closing bug.