Bug 123947

Summary: [Efl] Disable LTO when building cairo
Product: WebKit Reporter: Nick Diego Yamane (diegoyam) <nick.diego>
Component: WebKit EFLAssignee: Nick Diego Yamane (diegoyam) <nick.diego>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, gyuyoung.kim, laszlo.gombos, lucas.de.marchi, mrobinson
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Improved changelog description none

Nick Diego Yamane (diegoyam)
Reported 2013-11-06 18:10:03 PST
[Efl] Disable LTO when builing cairo
Attachments
Patch (1.45 KB, patch)
2013-11-06 18:12 PST, Nick Diego Yamane (diegoyam) 		no flags
DetailsFormatted DiffDiff
Patch (1.45 KB, patch)
2013-11-07 03:56 PST, Nick Diego Yamane (diegoyam) 		no flags
DetailsFormatted DiffDiff
Improved changelog description (1.65 KB, patch)
2013-11-07 04:12 PST, Nick Diego Yamane (diegoyam) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Nick Diego Yamane (diegoyam)
Comment 1 2013-11-06 18:12:26 PST
Created attachment 216253 [details] Patch
Laszlo Gombos
Comment 2 2013-11-06 20:31:47 PST
Should we consider a similar change for the gtk port as well ?
Gyuyoung Kim
Comment 3 2013-11-06 21:17:36 PST
(In reply to comment #2) > Should we consider a similar change for the gtk port as well ? +1. It would be good to fix gtk port as well.
Nick Diego Yamane (diegoyam)
Comment 4 2013-11-06 21:48:45 PST
(In reply to comment #3) > (In reply to comment #2) > > Should we consider a similar change for the gtk port as well ? > > +1. It would be good to fix gtk port as well. Ok. I'll send a similar patch to fix that in gtk.
Nick Diego Yamane (diegoyam)
Comment 5 2013-11-06 22:06:35 PST
(In reply to comment #4) > (In reply to comment #3) > > (In reply to comment #2) > > > Should we consider a similar change for the gtk port as well ? > > > > +1. It would be good to fix gtk port as well. > > Ok. I'll send a similar patch to fix that in gtk. https://bugs.webkit.org/show_bug.cgi?id=123954
Nick Diego Yamane (diegoyam)
Comment 6 2013-11-07 03:56:27 PST
Created attachment 216287 [details] Patch
Gyuyoung Kim
Comment 7 2013-11-07 03:57:19 PST
Comment on attachment 216253 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=216253&action=review > Tools/ChangeLog:8 > + - See: https://bugs.freedesktop.org/show_bug.cgi?id=60852 It seems to me patch description is not WebKit style. Please re-write description according to previous WebKit description.
Nick Diego Yamane (diegoyam)
Comment 8 2013-11-07 04:12:25 PST
Created attachment 216288 [details] Improved changelog description
WebKit Commit Bot
Comment 9 2013-11-07 04:44:34 PST
Comment on attachment 216288 [details] Improved changelog description Clearing flags on attachment: 216288 Committed r158845: <http://trac.webkit.org/changeset/158845>
WebKit Commit Bot
Comment 10 2013-11-07 04:44:38 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.