Remote Layer Tree: RemoteLayerBackingStore partial repaint is broken for the tile cache

• Component: WebKit2
• Status: RESOLVED FIXED

[Tim Horton]

Because of the way repaint rects work through TileController, we're repainting the whole tile every time.

[Tim Horton]

Created attachment 216346 [details]
patch

[WebKit Commit Bot]

Attachment 216346 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/WebCore.exp.in', u'Source/WebCore/platform/graphics/ca/PlatformCALayer.h', u'Source/WebCore/platform/graphics/ca/mac/PlatformCALayerMac.h', u'Source/WebCore/platform/graphics/ca/mac/PlatformCALayerMac.mm', u'Source/WebCore/platform/graphics/ca/mac/TileController.mm', u'Source/WebCore/platform/graphics/mac/WebLayer.h', u'Source/WebCore/platform/graphics/mac/WebLayer.mm', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/Shared/mac/RemoteLayerBackingStore.h', u'Source/WebKit2/Shared/mac/RemoteLayerBackingStore.mm', u'Source/WebKit2/WebProcess/WebPage/mac/PlatformCALayerRemote.cpp', u'Source/WebKit2/WebProcess/WebPage/mac/PlatformCALayerRemote.h']" exit_code: 1
Source/WebCore/platform/graphics/ca/mac/PlatformCALayerMac.h:144:  The parameter name "context" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 1 in 13 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Tim Horton]

Created attachment 216349 [details]
patch

[Build Bot]

Comment on attachment 216349 [details]
patch

Attachment 216349 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/22778309

[Build Bot]

Comment on attachment 216349 [details]
patch

Attachment 216349 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/22538328

[Build Bot]

Comment on attachment 216349 [details]
patch

Attachment 216349 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/22598413

[Tim Horton]

Created attachment 216416 [details]
accidental SPI

[Simon Fraser (smfr)]

Comment on attachment 216416 [details]
accidental SPI

View in context: https://bugs.webkit.org/attachment.cgi?id=216416&action=review

> Source/WebCore/ChangeLog:8
> +        Reviewed by NOBODY (OOPS!).
> +
> +        * platform/graphics/ca/PlatformCALayer.h:

High level summary please!

> Source/WebCore/ChangeLog:30
> +        has at least one layer in it (appending the clip bounds if we don't

one rect?

> Source/WebCore/platform/graphics/mac/WebLayer.mm:112
> +        graphicsContext.clip(rect);

In the one-rect case you're clipping here where you didn't before, but that's probably OK.

[Tim Horton]

http://trac.webkit.org/changeset/158982