Bug 123941

Summary: kTraceBufferLen is unused in default builds
Product: WebKit Reporter: Dean Jackson <dino>
Component: ANGLEAssignee: Dean Jackson <dino>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dbates, kondapallykalyan, roger_fong, thorton
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch thorton: review+

Description Dean Jackson 2013-11-06 17:09:46 PST 
In debug.cpp, kTraceBufferLen is not used unless TRACE_ENABLED is true. This causes newer versions of clang to throw a warning.

For now, add -Wno-error=unused-variable to the build flags.

<rdar://problem/14739718>
Comment 1 Dean Jackson 2013-11-06 17:11:59 PST 
Real radar is <rdar://problem/15409804>
Comment 2 Dean Jackson 2013-11-06 17:13:57 PST 
Created attachment 216246 [details]
Patch
Comment 3 Dean Jackson 2013-11-06 17:27:06 PST 
Created attachment 216249 [details]
Patch
Comment 4 Tim Horton 2013-11-06 17:28:04 PST 
Comment on attachment 216249 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=216249&action=review

Much better.

> Source/ThirdParty/ANGLE/src/compiler/debug.cpp:46
> +#if defined(__clang__)
> +#pragma clang diagnostic pop
> +#endif

This should wrap just the constant.
Comment 5 Dean Jackson 2013-11-06 17:40:01 PST 
Committed r158807: <http://trac.webkit.org/changeset/158807>
Comment 6 Tim Horton 2013-11-06 17:58:27 PST 
Probably should have used "GCC diagnostic push" and no #if defined(__clang__)
Comment 7 Daniel Bates 2013-12-03 11:39:30 PST 
This change was inadvertently reverted in <http://trac.webkit.org/changeset/159533> (bug #124615). I committed a revised fix for this issue in <https://bugs.webkit.org/show_bug.cgi?id=125164>, which was accepted by the ANGLE project: <https://code.google.com/p/angleproject/issues/detail?id=534>.