Bug 123930

Summary: Move allowed classes handling to decodeObject
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: New BugsAssignee: Anders Carlsson <andersca>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch kling: review+

Description Anders Carlsson 2013-11-06 14:47:46 PST
Move allowed classes handling to decodeObject
Comment 1 Anders Carlsson 2013-11-06 14:51:46 PST
Created attachment 216227 [details]
Patch
Comment 2 Andreas Kling 2013-11-06 14:56:22 PST
Comment on attachment 216227 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=216227&action=review

r=me

> Source/WebKit2/Shared/API/Cocoa/WKRemoteObjectCoder.mm:453
> +    if (!allowedClasses)
> +        allowedClasses = decoder->_allowedClasses;

Not a fan of overwriting arguments like this. I like your IRC version better.
Comment 3 Anders Carlsson 2013-11-06 15:02:44 PST
Committed r158797: <http://trac.webkit.org/changeset/158797>