Summary: | [Gtk] Remove old takeFocus() method from PageClientImpl and mark methods as OVERRIDE | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Brendan Long <b.long> | ||||
Component: | New Bugs | Assignee: | Brendan Long <b.long> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | cgarcia, commit-queue, gustavo, mrobinson | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Brendan Long
2013-11-06 13:07:22 PST
Created attachment 216220 [details]
Patch
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API Comment on attachment 216220 [details]
Patch
Cool, thanks for the patch, I think we could make the class FINAL too.
Comment on attachment 216220 [details] Patch Clearing flags on attachment: 216220 Committed r158827: <http://trac.webkit.org/changeset/158827> All reviewed patches have been landed. Closing bug. |