Bug 123919

Summary: [Gtk] Remove old takeFocus() method from PageClientImpl and mark methods as OVERRIDE
Product: WebKit Reporter: Brendan Long <b.long>
Component: New BugsAssignee: Brendan Long <b.long>
Status: RESOLVED FIXED    
Severity: Normal CC: cgarcia, commit-queue, gns, mrobinson
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Brendan Long 2013-11-06 13:07:22 PST
[Gtk] Remove old takeFocus() method from PageClientImpl and mark methods as OVERRIDE
Comment 1 Brendan Long 2013-11-06 13:44:42 PST
Created attachment 216220 [details]
Patch
Comment 2 WebKit Commit Bot 2013-11-06 13:46:36 PST
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 3 Carlos Garcia Campos 2013-11-06 23:38:21 PST
Comment on attachment 216220 [details]
Patch

Cool, thanks for the patch, I think we could make the class FINAL too.
Comment 4 WebKit Commit Bot 2013-11-07 00:03:08 PST
Comment on attachment 216220 [details]
Patch

Clearing flags on attachment: 216220

Committed r158827: <http://trac.webkit.org/changeset/158827>
Comment 5 WebKit Commit Bot 2013-11-07 00:03:11 PST
All reviewed patches have been landed.  Closing bug.