Bug 123919 - [Gtk] Remove old takeFocus() method from PageClientImpl and mark methods as OVERRIDE
Summary: [Gtk] Remove old takeFocus() method from PageClientImpl and mark methods as O...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brendan Long
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-11-06 13:07 PST by Brendan Long
Modified: 2013-11-07 00:03 PST (History)
4 users (show)

See Also:

Attachments
Patch (7.34 KB, patch)
2013-11-06 13:44 PST, Brendan Long 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brendan Long 2013-11-06 13:07:22 PST 
[Gtk] Remove old takeFocus() method from PageClientImpl and mark methods as OVERRIDE
Comment 1 Brendan Long 2013-11-06 13:44:42 PST 
Created attachment 216220 [details]
Patch
Comment 2 WebKit Commit Bot 2013-11-06 13:46:36 PST 
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 3 Carlos Garcia Campos 2013-11-06 23:38:21 PST 
Comment on attachment 216220 [details]
Patch

Cool, thanks for the patch, I think we could make the class FINAL too.
Comment 4 WebKit Commit Bot 2013-11-07 00:03:08 PST 
Comment on attachment 216220 [details]
Patch

Clearing flags on attachment: 216220

Committed r158827: <http://trac.webkit.org/changeset/158827>
Comment 5 WebKit Commit Bot 2013-11-07 00:03:11 PST 
All reviewed patches have been landed.  Closing bug.