RESOLVED FIXED 123919
[Gtk] Remove old takeFocus() method from PageClientImpl and mark methods as OVERRIDE 
https://bugs.webkit.org/show_bug.cgi?id=123919
Summary [Gtk] Remove old takeFocus() method from PageClientImpl and mark methods as O...
Brendan Long
Reported 2013-11-06 13:07:22 PST
[Gtk] Remove old takeFocus() method from PageClientImpl and mark methods as OVERRIDE
Attachments
Patch (7.34 KB, patch)
2013-11-06 13:44 PST, Brendan Long 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Brendan Long
Comment 1 2013-11-06 13:44:42 PST
Created attachment 216220 [details] Patch
WebKit Commit Bot
Comment 2 2013-11-06 13:46:36 PST
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Carlos Garcia Campos
Comment 3 2013-11-06 23:38:21 PST
Comment on attachment 216220 [details] Patch Cool, thanks for the patch, I think we could make the class FINAL too.
WebKit Commit Bot
Comment 4 2013-11-07 00:03:08 PST
Comment on attachment 216220 [details] Patch Clearing flags on attachment: 216220 Committed r158827: <http://trac.webkit.org/changeset/158827>
WebKit Commit Bot
Comment 5 2013-11-07 00:03:11 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.