Summary: | [GTK] Use deprecation guards around deprecated API in GObject DOM bindings | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Carlos Garcia Campos <cgarcia> | ||||
Component: | Bindings | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | cdumez, commit-queue, gustavo, mrobinson | ||||
Priority: | P2 | Keywords: | Gtk | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Carlos Garcia Campos
2013-11-06 09:38:29 PST
Created attachment 216185 [details]
Patch
Comment on attachment 216185 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=216185&action=review Looking good, with one small nit about the comment style. > Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm:1009 > + push(@hBody, "#endif /* WEBKIT_DISABLE_DEPRECATED */\n"); See below. > Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm:1234 > + push(@cBody, "#endif /* WEBKIT_DISABLE_DEPRECATED */\n"); See below. > Source/WebCore/bindings/scripts/test/GObject/WebKitDOMTestEventTarget.cpp:167 > +#endif /* WEBKIT_DISABLE_DEPRECATED */ I think we typically use C++ style comments for this sort of thing. (In reply to comment #2) > (From update of attachment 216185 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=216185&action=review > > Looking good, with one small nit about the comment style. > > > Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm:1009 > > + push(@hBody, "#endif /* WEBKIT_DISABLE_DEPRECATED */\n"); > > See below. > > > Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm:1234 > > + push(@cBody, "#endif /* WEBKIT_DISABLE_DEPRECATED */\n"); > > See below. > > > Source/WebCore/bindings/scripts/test/GObject/WebKitDOMTestEventTarget.cpp:167 > > +#endif /* WEBKIT_DISABLE_DEPRECATED */ > > I think we typically use C++ style comments for this sort of thing. Yes, that's what I thought, but I checked the feature guards and they all use /* */. (In reply to comment #3) > Yes, that's what I thought, but I checked the feature guards and they all use /* */. I think this is just an oversight. The bindings are trending toward following the style guidelines over time. :) (In reply to comment #4) > (In reply to comment #3) > > > Yes, that's what I thought, but I checked the feature guards and they all use /* */. > > I think this is just an oversight. The bindings are trending toward following the style guidelines over time. :) Yes, I guess, I'll change it before landing then. (In reply to comment #5) > Yes, I guess, I'll change it before landing then. Cool. Thanks for the patch! (In reply to comment #6) > (In reply to comment #5) > > > Yes, I guess, I'll change it before landing then. > > Cool. Thanks for the patch! hmm, is it really ok to use // in public headers that can be included from C code? or do you want me to change only the comments in the cpp file? Sorry. Only the CPP code. Committed r158907: <http://trac.webkit.org/changeset/158907> |