Bug 123868

Summary:

Change the order of conditions to avoid computing rendererIsEditable()

Product:

WebKit

Reporter:

Ryosuke Niwa <rniwa>

Component:

HTML Editing

Assignee:

Ryosuke Niwa <rniwa>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

benjamin, commit-queue, darin, enrica, esprehn+autocc, kangil.han, kling, koivisto

Priority:

Keywords:

BlinkMergeCandidate

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Merge the cleanup	kling: review+

Description Ryosuke Niwa 2013-11-05 22:06:47 PST

Merge https://chromium.googlesource.com/chromium/blink/+/c89b413ff0fc4aafa0c71d180b0b1e131bb37707

When we need both Node::renderer() and Node::rendererIsEditable()
conditions to be true to perform some operation, it is more effective
to check for renderer() first, so that if this condition fails we can
avoid unnecessary computation of rendererIsEditable().

Comment 1 Ryosuke Niwa 2013-11-05 22:10:06 PST

Created attachment 216132 [details]
Merge the cleanup

Comment 2 Ryosuke Niwa 2013-11-05 22:12:46 PST

Committed r158723: <http://trac.webkit.org/changeset/158723>