Bug 123868

Summary: Change the order of conditions to avoid computing rendererIsEditable()
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: HTML EditingAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, commit-queue, darin, enrica, esprehn+autocc, kangil.han, kling, koivisto
Priority: P2 Keywords: BlinkMergeCandidate
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Merge the cleanup kling: review+

Ryosuke Niwa
Reported 2013-11-05 22:06:47 PST
Merge https://chromium.googlesource.com/chromium/blink/+/c89b413ff0fc4aafa0c71d180b0b1e131bb37707 When we need both Node::renderer() and Node::rendererIsEditable() conditions to be true to perform some operation, it is more effective to check for renderer() first, so that if this condition fails we can avoid unnecessary computation of rendererIsEditable().
Attachments
Merge the cleanup (2.98 KB, patch)
2013-11-05 22:10 PST, Ryosuke Niwa 		kling: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2013-11-05 22:10:06 PST
Created attachment 216132 [details] Merge the cleanup
Ryosuke Niwa
Comment 2 2013-11-05 22:12:46 PST
Committed r158723: <http://trac.webkit.org/changeset/158723>
Note You need to log in before you can comment on or make changes to this bug.