Summary: | crash when executing Thunk checks on ARM | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Mandeep Singh Baines <mandeep.baines> | ||||||||
Component: | JavaScriptCore | Assignee: | Nobody <webkit-unassigned> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | buildbot, fpizlo, jbriance, msaboff, ossy, rniwa | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Bug Depends on: | |||||||||||
Bug Blocks: | 108645 | ||||||||||
Attachments: |
|
Description
Mandeep Singh Baines
2013-11-05 19:06:00 PST
Created attachment 216194 [details]
the patch
This crash affects all architectures. Due to random luck, I was only see a crash on ARM.
Attached is a fix which changes the thunk to use the regT* convention for storing the callee that was previously used by the baseline JIT thunk.
Comment on attachment 216194 [details] the patch Attachment 216194 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/22718211 New failing tests: js/regress/emscripten-cube2hash.html cssom/cssvalue-comparison.html js/dom/JSON-parse.html fast/canvas/canvas-blending-pattern-over-pattern.html inspector-protocol/debugger/call-frame-this-strict.html js/mozilla/strict/8.12.5.html fast/canvas/canvas-blending-image-over-image.html cssom/cssstyledeclaration-csstext-final-delimiter.html fast/canvas/webgl/array-unit-tests.html cssom/cssimportrule-media.html fast/dom/SelectorAPI/resig-SelectorsAPI-test.xhtml js/mozilla/strict/13.1.html http/tests/canvas/webgl/origin-clean-conformance.html fast/regions/webkit-region-syntax-space.html fast/media/mq-color-index-02.html inspector-protocol/dom/remove-multiple-nodes.html fast/media/w3c/test_media_queries.html fast/dom/Document/CaretRangeFromPoint/hittest-relative-to-viewport.html jquery/attributes.html fast/xpath/xpath-iterator-result-should-mark-its-nodeset.html fast/media/mq-js-update-media.html inspector-protocol/debugger/setBreakpoint-condition.html js/mozilla/strict/11.1.5.html inspector-protocol/debugger/call-frame-this-nonstrict.html fast/canvas/webgl/arraybuffer-transfer-of-control.html fast/regions/webkit-flow-into-parsing.html inspector-protocol/debugger/setBreakpoint-actions.html js/dom/JSON-stringify.html jquery/core.html inspector-protocol/model/content-flow-content-nodes.html Created attachment 216303 [details]
Archive of layout-test-results from webkit-ews-07 for mac-mountainlion
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-07 Port: mac-mountainlion Platform: Mac OS X 10.8.5
What ARM architecture do you use? If it's ARM_TRADITIONAL, the last stable revision I know is r158882 + changeset r158915 Comment on attachment 216194 [details] the patch Attachment 216194 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/22598522 New failing tests: cssom/cssvalue-comparison.html js/dom/JSON-parse.html fast/canvas/canvas-blending-pattern-over-pattern.html inspector-protocol/debugger/call-frame-this-strict.html js/mozilla/strict/8.12.5.html inspector-protocol/debugger/setBreakpoint-options-exception.html fast/canvas/canvas-blending-image-over-image.html cssom/cssstyledeclaration-csstext-final-delimiter.html fast/canvas/webgl/array-unit-tests.html cssom/cssimportrule-media.html fast/dom/SelectorAPI/resig-SelectorsAPI-test.xhtml http/tests/canvas/webgl/origin-clean-conformance.html fast/regions/webkit-region-syntax-space.html fast/media/mq-color-index-02.html inspector-protocol/dom/remove-multiple-nodes.html fast/media/w3c/test_media_queries.html fast/dom/Document/CaretRangeFromPoint/hittest-relative-to-viewport.html jquery/attributes.html jquery/data.html fast/media/mq-js-update-media.html inspector-protocol/debugger/setBreakpoint-condition.html js/mozilla/strict/11.1.5.html inspector-protocol/debugger/call-frame-this-nonstrict.html fast/canvas/webgl/arraybuffer-transfer-of-control.html fast/regions/webkit-flow-into-parsing.html inspector-protocol/debugger/setBreakpoint-actions.html js/dom/JSON-stringify.html jquery/core.html inspector-protocol/model/content-flow-content-nodes.html jquery/css.html Created attachment 216395 [details]
Archive of layout-test-results from webkit-ews-15 for mac-mountainlion-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-15 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Hi Julien, Thanks for the reply. I'm building for ARMv7. I'm very new to WebKit. This is actually the first time I've sent a patch. Does the patch look reasonable (minus the tests that seem to be failing)? Still getting my head around JSC. So there are stable versions? Where is the list of stable versions posted? Regards, Mandeep (In reply to comment #7) > I'm very new to WebKit. This is actually the first time I've sent a patch. That's nice to read ! > Does the patch look reasonable (minus the tests that seem to be failing)? Still getting my head around JSC. Honestly, I don't think so, see https://bugs.webkit.org/show_bug.cgi?id=123277 for further information about this. Moreover, Mark's already fixed your issue with changeset 158315 (http://trac.webkit.org/changeset/158315). > So there are stable versions? Yes, fortunately ;) > Where is the list of stable versions posted? As far as I know, there's no such list. If you want to get this information, you might want to set up a buildbot running jsc tests for ARMv7 architecture to track build status and regressions. You also might want to add your bot in the webkit waterfall (http://build.webkit.org/waterfall). |