Bug 123844

Summary: Change ctiTrampoline into a thunk
Product: WebKit Reporter: Michael Saboff <msaboff>
Component: JavaScriptCoreAssignee: Michael Saboff <msaboff>
Status: RESOLVED FIXED    
Severity: Normal CC: eflews.bot, gtk-ews, gyuyoung.kim, philn, ralpht+bugs, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 116888    
Attachments:
Description Flags
Patch
gtk-ews: commit-queue-
Updated with speculative build fixes fpizlo: review+, eflews.bot: commit-queue-

Description Michael Saboff 2013-11-05 17:53:32 PST 
Given that moving JSC to the C++ stack will require changes to all flavors of ctiTrampoline, it makes sense to convert it and its companion, ctiOpThrowNotCaught, to a thunks.
Comment 1 Michael Saboff 2013-11-05 18:47:42 PST 
Created attachment 216107 [details]
Patch

The changes for ARM traditional, ARM64, MIPS, SH4 and Windows are speculative.  The EWS bots will test some of these.
Comment 2 kov's GTK+ EWS bot 2013-11-05 19:05:12 PST 
Comment on attachment 216107 [details]
Patch

Attachment 216107 [details] did not pass gtk-ews (gtk):
Output: http://webkit-queues.appspot.com/results/21248083
Comment 3 Michael Saboff 2013-11-05 21:22:37 PST 
Created attachment 216122 [details]
Updated with speculative build fixes
Comment 4 EFL EWS Bot 2013-11-05 21:40:24 PST 
Comment on attachment 216122 [details]
Updated with speculative build fixes

Attachment 216122 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/21668004
Comment 5 Filip Pizlo 2013-11-06 08:39:44 PST 
Comment on attachment 216122 [details]
Updated with speculative build fixes

Cool!
Comment 6 Michael Saboff 2013-11-06 09:27:58 PST 
Committed r158751: <http://trac.webkit.org/changeset/158751>
Comment 7 Michael Saboff 2013-11-20 10:17:59 PST 
*** Bug 123908 has been marked as a duplicate of this bug. ***