| Summary: | [Cocoa] History delegate | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | mitz | ||||||
| Component: | WebKit2 | Assignee: | mitz | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | commit-queue, eflews.bot, gtk-ews, gyuyoung.kim, sergio, xan.lopez | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
mitz
2013-11-05 16:30:46 PST
Created attachment 216095 [details]
Add WKProcessGroupHistoryDelegate and WKNavigationData
Attachment 216095 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/Shared/Cocoa/APIObject.mm', u'Source/WebKit2/Shared/Cocoa/WKNSString.h', u'Source/WebKit2/Shared/Cocoa/WKNSURL.h', u'Source/WebKit2/UIProcess/API/C/WKNavigationData.cpp', u'Source/WebKit2/UIProcess/API/C/WKNavigationData.h', u'Source/WebKit2/UIProcess/API/C/WKNavigationDataRef.cpp', u'Source/WebKit2/UIProcess/API/C/WKNavigationDataRef.h', u'Source/WebKit2/UIProcess/API/mac/WKProcessGroup.h', u'Source/WebKit2/UIProcess/API/mac/WKProcessGroup.mm', u'Source/WebKit2/UIProcess/Cocoa/WKNavigationData.h', u'Source/WebKit2/UIProcess/Cocoa/WKNavigationData.mm', u'Source/WebKit2/UIProcess/Cocoa/WKNavigationDataInternal.h', u'Source/WebKit2/WebKit2.xcodeproj/project.pbxproj']" exit_code: 1
Source/WebKit2/UIProcess/Cocoa/WKNavigationDataInternal.h:34: More than one command on the same line [whitespace/newline] [4]
Source/WebKit2/Shared/Cocoa/WKNSString.h:34: More than one command on the same line [whitespace/newline] [4]
Source/WebKit2/Shared/Cocoa/WKNSURL.h:34: More than one command on the same line [whitespace/newline] [4]
Total errors found: 3 in 12 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 216102 [details]
Add WKBrowsingContextHistoryDelegate and WKNavigationData
Attachment 216102 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/Shared/Cocoa/APIObject.mm', u'Source/WebKit2/Shared/Cocoa/WKNSString.h', u'Source/WebKit2/Shared/Cocoa/WKNSURL.h', u'Source/WebKit2/UIProcess/API/C/WKNavigationData.cpp', u'Source/WebKit2/UIProcess/API/C/WKNavigationData.h', u'Source/WebKit2/UIProcess/API/C/WKNavigationDataRef.cpp', u'Source/WebKit2/UIProcess/API/C/WKNavigationDataRef.h', u'Source/WebKit2/UIProcess/API/mac/WKBrowsingContextController.h', u'Source/WebKit2/UIProcess/API/mac/WKProcessGroup.mm', u'Source/WebKit2/UIProcess/Cocoa/WKBrowsingContextHistoryDelegate.h', u'Source/WebKit2/UIProcess/Cocoa/WKNavigationData.h', u'Source/WebKit2/UIProcess/Cocoa/WKNavigationData.mm', u'Source/WebKit2/UIProcess/Cocoa/WKNavigationDataInternal.h', u'Source/WebKit2/WebKit2.xcodeproj/project.pbxproj']" exit_code: 1
Source/WebKit2/UIProcess/Cocoa/WKNavigationDataInternal.h:34: More than one command on the same line [whitespace/newline] [4]
Source/WebKit2/Shared/Cocoa/WKNSString.h:34: More than one command on the same line [whitespace/newline] [4]
Source/WebKit2/Shared/Cocoa/WKNSURL.h:34: More than one command on the same line [whitespace/newline] [4]
Total errors found: 3 in 13 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 216102 [details] Add WKBrowsingContextHistoryDelegate and WKNavigationData Attachment 216102 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/21318052 Comment on attachment 216102 [details] Add WKBrowsingContextHistoryDelegate and WKNavigationData Attachment 216102 [details] did not pass gtk-ews (gtk): Output: http://webkit-queues.appspot.com/results/21368047 Committed <http://trac.webkit.org/r158753>. EFL build fix after the WKNavigationData.h => WKNavigationDataRef.h rename: https://bugs.webkit.org/show_bug.cgi?id=123923 |