Bug 123837

Summary: [Cocoa] History delegate
Product: WebKit Reporter: mitz
Component: WebKit2Assignee: mitz
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eflews.bot, gtk-ews, gyuyoung.kim, sergio, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Add WKProcessGroupHistoryDelegate and WKNavigationData
none
Add WKBrowsingContextHistoryDelegate and WKNavigationData sam: review+, eflews.bot: commit-queue-

mitz
Reported 2013-11-05 16:30:46 PST
[Cocoa] History delegate
Attachments
Add WKProcessGroupHistoryDelegate and WKNavigationData (40.14 KB, patch)
2013-11-05 16:40 PST, mitz 		no flags
DetailsFormatted DiffDiff
Add WKBrowsingContextHistoryDelegate and WKNavigationData (41.91 KB, patch)
2013-11-05 17:28 PST, mitz 		sam: review+
eflews.bot: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
mitz
Comment 1 2013-11-05 16:40:01 PST
Created attachment 216095 [details] Add WKProcessGroupHistoryDelegate and WKNavigationData
WebKit Commit Bot
Comment 2 2013-11-05 16:41:43 PST
Attachment 216095 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/Shared/Cocoa/APIObject.mm', u'Source/WebKit2/Shared/Cocoa/WKNSString.h', u'Source/WebKit2/Shared/Cocoa/WKNSURL.h', u'Source/WebKit2/UIProcess/API/C/WKNavigationData.cpp', u'Source/WebKit2/UIProcess/API/C/WKNavigationData.h', u'Source/WebKit2/UIProcess/API/C/WKNavigationDataRef.cpp', u'Source/WebKit2/UIProcess/API/C/WKNavigationDataRef.h', u'Source/WebKit2/UIProcess/API/mac/WKProcessGroup.h', u'Source/WebKit2/UIProcess/API/mac/WKProcessGroup.mm', u'Source/WebKit2/UIProcess/Cocoa/WKNavigationData.h', u'Source/WebKit2/UIProcess/Cocoa/WKNavigationData.mm', u'Source/WebKit2/UIProcess/Cocoa/WKNavigationDataInternal.h', u'Source/WebKit2/WebKit2.xcodeproj/project.pbxproj']" exit_code: 1 Source/WebKit2/UIProcess/Cocoa/WKNavigationDataInternal.h:34: More than one command on the same line [whitespace/newline] [4] Source/WebKit2/Shared/Cocoa/WKNSString.h:34: More than one command on the same line [whitespace/newline] [4] Source/WebKit2/Shared/Cocoa/WKNSURL.h:34: More than one command on the same line [whitespace/newline] [4] Total errors found: 3 in 12 files If any of these errors are false positives, please file a bug against check-webkit-style.
mitz
Comment 3 2013-11-05 17:28:43 PST
Created attachment 216102 [details] Add WKBrowsingContextHistoryDelegate and WKNavigationData
WebKit Commit Bot
Comment 4 2013-11-05 17:30:11 PST
Attachment 216102 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/Shared/Cocoa/APIObject.mm', u'Source/WebKit2/Shared/Cocoa/WKNSString.h', u'Source/WebKit2/Shared/Cocoa/WKNSURL.h', u'Source/WebKit2/UIProcess/API/C/WKNavigationData.cpp', u'Source/WebKit2/UIProcess/API/C/WKNavigationData.h', u'Source/WebKit2/UIProcess/API/C/WKNavigationDataRef.cpp', u'Source/WebKit2/UIProcess/API/C/WKNavigationDataRef.h', u'Source/WebKit2/UIProcess/API/mac/WKBrowsingContextController.h', u'Source/WebKit2/UIProcess/API/mac/WKProcessGroup.mm', u'Source/WebKit2/UIProcess/Cocoa/WKBrowsingContextHistoryDelegate.h', u'Source/WebKit2/UIProcess/Cocoa/WKNavigationData.h', u'Source/WebKit2/UIProcess/Cocoa/WKNavigationData.mm', u'Source/WebKit2/UIProcess/Cocoa/WKNavigationDataInternal.h', u'Source/WebKit2/WebKit2.xcodeproj/project.pbxproj']" exit_code: 1 Source/WebKit2/UIProcess/Cocoa/WKNavigationDataInternal.h:34: More than one command on the same line [whitespace/newline] [4] Source/WebKit2/Shared/Cocoa/WKNSString.h:34: More than one command on the same line [whitespace/newline] [4] Source/WebKit2/Shared/Cocoa/WKNSURL.h:34: More than one command on the same line [whitespace/newline] [4] Total errors found: 3 in 13 files If any of these errors are false positives, please file a bug against check-webkit-style.
EFL EWS Bot
Comment 5 2013-11-05 17:33:07 PST
Comment on attachment 216102 [details] Add WKBrowsingContextHistoryDelegate and WKNavigationData Attachment 216102 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/21318052
kov's GTK+ EWS bot
Comment 6 2013-11-05 17:43:44 PST
Comment on attachment 216102 [details] Add WKBrowsingContextHistoryDelegate and WKNavigationData Attachment 216102 [details] did not pass gtk-ews (gtk): Output: http://webkit-queues.appspot.com/results/21368047
mitz
Comment 7 2013-11-06 09:34:37 PST
Committed <http://trac.webkit.org/r158753>.
Sergio Correia (qrwteyrutiyoup)
Comment 8 2013-11-06 14:08:07 PST
EFL build fix after the WKNavigationData.h => WKNavigationDataRef.h rename: https://bugs.webkit.org/show_bug.cgi?id=123923
Note You need to log in before you can comment on or make changes to this bug.