Bug 123835 – Support iteration of the Arguments object

• Component: New Bugs
• Status: RESOLVED FIXED

[Oliver Hunt]

Support iteration of the Arguments object

[Oliver Hunt]

Created attachment 216094 [details]
Patch

[EFL EWS Bot]

Comment on attachment 216094 [details]
Patch

Attachment 216094 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/21248053

[Oliver Hunt]

Created attachment 216096 [details]
Patch

[Mark Lam]

Comment on attachment 216096 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=216096&action=review

r=me with comments addressed.

> Source/JavaScriptCore/runtime/CommonIdentifiers.h:31
>      macro(Array) \
> +    macro(ArgumentsIterator) \

Sort ArgumentsIterator before Array.

> LayoutTests/js/script-tests/arguments-iterator.js:57
> +function testStrict() {
> +    var i = 0;
> +    for (arg of arguments) {
> +        realArg = arguments[i++];
> +        shouldBeTrue("arg === realArg");
> +    }
> +    iteratedArgumentsLength = i;
> +    actualArgumentsLength = arguments.length;
> +    shouldBe("actualArgumentsLength", "iteratedArgumentsLength");
> +}
> +
> +testStrict();
> +testStrict("a");
> +testStrict("a", "b");
> +testStrict({})

What makes this test case "strict"?  It looks the identical to the non-strict "test()" test case above.

[Oliver Hunt]

Committed r158793: <http://trac.webkit.org/changeset/158793>