Bug 123807

Summary: [mips] Make regTx registers match between JSInterfaceJIT and GPRInfo for the MIPS backend.
Product: WebKit Reporter: Julien Brianceau <jbriance>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, fpizlo, mark.lam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Make regTx registers match between JSInterfaceJIT and GPRInfo in MIPS backend.
none
Make regTx registers match between JSInterfaceJIT and GPRInfo in MIPS backen (with ASSERT fixed). none

Julien Brianceau
Reported 2013-11-05 09:07:15 PST
As discussed in https://bugs.webkit.org/show_bug.cgi?id=123799, it would be better for backends that JSInterfaceJIT::regTx and GPRInfo::regTx match the same actual register.
Attachments
Make regTx registers match between JSInterfaceJIT and GPRInfo in MIPS backend. (3.04 KB, patch)
2013-11-05 09:19 PST, Julien Brianceau 		no flags
DetailsFormatted DiffDiff
Make regTx registers match between JSInterfaceJIT and GPRInfo in MIPS backen (with ASSERT fixed). (3.11 KB, patch)
2013-11-05 09:30 PST, Julien Brianceau 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Julien Brianceau
Comment 1 2013-11-05 09:19:56 PST
Created attachment 216045 [details] Make regTx registers match between JSInterfaceJIT and GPRInfo in MIPS backend. It turns out that this patch also fixes many issues seen during run-layout-jsc tests on my MIPS board.
Julien Brianceau
Comment 2 2013-11-05 09:29:37 PST
Comment on attachment 216045 [details] Make regTx registers match between JSInterfaceJIT and GPRInfo in MIPS backend. Forgot to change the ASSERT(reg < 16) in toIndex
Julien Brianceau
Comment 3 2013-11-05 09:30:23 PST
Created attachment 216047 [details] Make regTx registers match between JSInterfaceJIT and GPRInfo in MIPS backen (with ASSERT fixed).
Mark Lam
Comment 4 2013-11-05 09:32:30 PST
Comment on attachment 216047 [details] Make regTx registers match between JSInterfaceJIT and GPRInfo in MIPS backen (with ASSERT fixed). r=me
WebKit Commit Bot
Comment 5 2013-11-05 10:03:59 PST
Comment on attachment 216047 [details] Make regTx registers match between JSInterfaceJIT and GPRInfo in MIPS backen (with ASSERT fixed). Clearing flags on attachment: 216047 Committed r158677: <http://trac.webkit.org/changeset/158677>
WebKit Commit Bot
Comment 6 2013-11-05 10:04:02 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.