Bug 123786

Summary: [WK2] Add a WebKit2 API for Geolocation's highAccuracy
Product: WebKit Reporter: Benjamin Poulain <benjamin>
Component: New BugsAssignee: Benjamin Poulain <benjamin>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eflews.bot, gyuyoung.kim, hugo.lima, philn, rakuco, rniwa, sam, xan.lopez, zan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Benjamin Poulain
Reported 2013-11-04 20:55:12 PST
[WK2] Add a WebKit2 API for Geolocation's highAccuracy
Attachments
Patch (43.79 KB, patch)
2013-11-04 21:06 PST, Benjamin Poulain 		no flags
DetailsFormatted DiffDiff
Patch (43.76 KB, patch)
2013-11-04 21:18 PST, Benjamin Poulain 		no flags
DetailsFormatted DiffDiff
Patch (43.94 KB, patch)
2013-11-04 21:43 PST, Benjamin Poulain 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Benjamin Poulain
Comment 1 2013-11-04 21:06:25 PST
Created attachment 215997 [details] Patch
Benjamin Poulain
Comment 2 2013-11-04 21:08:46 PST
*** Bug 120136 has been marked as a duplicate of this bug. ***
EFL EWS Bot
Comment 3 2013-11-04 21:16:05 PST
Comment on attachment 215997 [details] Patch Attachment 215997 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/21008003
Benjamin Poulain
Comment 4 2013-11-04 21:18:14 PST
Created attachment 215998 [details] Patch
EFL EWS Bot
Comment 5 2013-11-04 21:25:46 PST
Comment on attachment 215998 [details] Patch Attachment 215998 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/20978053
Benjamin Poulain
Comment 6 2013-11-04 21:43:06 PST
Created attachment 216001 [details] Patch
Darin Adler
Comment 7 2013-11-05 09:04:01 PST
Comment on attachment 216001 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=216001&action=review > Source/WebKit2/UIProcess/WebGeolocationManagerProxy.cpp:101 > + m_provider.setEnableHighAccuracy(this, isHighAccuracyEnabled()); > m_provider.startUpdating(this); Too bad we always have to send two messages here. Seems to me that we could have startUpdating take the high accuracy boolean, and/or combine startUpdating and setEnableHighAccuracy into a single message.
Benjamin Poulain
Comment 8 2013-11-05 13:13:46 PST
(In reply to comment #7) > (From update of attachment 216001 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=216001&action=review > > > Source/WebKit2/UIProcess/WebGeolocationManagerProxy.cpp:101 > > + m_provider.setEnableHighAccuracy(this, isHighAccuracyEnabled()); > > m_provider.startUpdating(this); > > Too bad we always have to send two messages here. Seems to me that we could have startUpdating take the high accuracy boolean, and/or combine startUpdating and setEnableHighAccuracy into a single message. Most system do not handle setEnableHighAccuracy() and the callback function will be null. I could make a new startUpdating but I don't think it is worth is since the other API is already widely used.
Benjamin Poulain
Comment 9 2013-11-05 13:15:07 PST
Comment on attachment 216001 [details] Patch Clearing flags on attachment: 216001 Committed r158689: <http://trac.webkit.org/changeset/158689>
Benjamin Poulain
Comment 10 2013-11-05 13:15:09 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.