Bug 123784

Summary:

FTL should support PutById

Product:

WebKit

Reporter:

Filip Pizlo <fpizlo>

Component:

JavaScriptCore

Assignee:

Filip Pizlo <fpizlo>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

barraclough, commit-queue, ggaren, mark.lam, mhahnenberg, msaboff, nrotem, oliver, sam

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

112840

Attachments:

Description	Flags
work in progress	none
the patch	none
the patch	ggaren: review+

Filip Pizlo

Reported 2013-11-04 20:35:54 PST

Obviously.

Attachments
work in progress (17.58 KB, patch) 2013-11-04 21:32 PST, Filip Pizlo	no flags	Details Formatted Diff Diff
the patch (19.32 KB, patch) 2013-11-04 23:37 PST, Filip Pizlo	no flags	Details Formatted Diff Diff
the patch (19.31 KB, patch) 2013-11-05 09:08 PST, Filip Pizlo	ggaren: review+	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Filip Pizlo

Comment 1 2013-11-04 21:32:33 PST

Created attachment 215999 [details] work in progress

Filip Pizlo

Comment 2 2013-11-04 23:37:36 PST

Created attachment 216008 [details] the patch

WebKit Commit Bot

Comment 3 2013-11-04 23:40:01 PST

Attachment 216008 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source/JavaScriptCore/ftl/FTLAbbreviations.h', u'Source/JavaScriptCore/ftl/FTLCapabilities.cpp', u'Source/JavaScriptCore/ftl/FTLCompile.cpp', u'Source/JavaScriptCore/ftl/FTLInlineCacheDescriptor.h', u'Source/JavaScriptCore/ftl/FTLIntrinsicRepository.h', u'Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp', u'Source/JavaScriptCore/ftl/FTLOutput.h', u'Source/JavaScriptCore/ftl/FTLSlowPathCall.cpp', u'Source/JavaScriptCore/ftl/FTLSlowPathCall.h', u'Source/JavaScriptCore/ftl/FTLState.h', u'Source/JavaScriptCore/jit/CCallHelpers.h', u'Source/JavaScriptCore/runtime/Executable.h']" exit_code: 1 Source/JavaScriptCore/ftl/FTLSlowPathCall.h:64: The parameter name "object" adds no information, so it should be removed. [readability/parameter_name] [5] Source/JavaScriptCore/ftl/FTLCompile.cpp:121: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] Source/JavaScriptCore/ftl/FTLCompile.cpp:134: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] Total errors found: 3 in 13 files If any of these errors are false positives, please file a bug against check-webkit-style.

Filip Pizlo

Comment 4 2013-11-05 09:08:35 PST

Created attachment 216044 [details] the patch

WebKit Commit Bot

Comment 5 2013-11-05 09:10:02 PST

Attachment 216044 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source/JavaScriptCore/ftl/FTLAbbreviations.h', u'Source/JavaScriptCore/ftl/FTLCapabilities.cpp', u'Source/JavaScriptCore/ftl/FTLCompile.cpp', u'Source/JavaScriptCore/ftl/FTLInlineCacheDescriptor.h', u'Source/JavaScriptCore/ftl/FTLIntrinsicRepository.h', u'Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp', u'Source/JavaScriptCore/ftl/FTLOutput.h', u'Source/JavaScriptCore/ftl/FTLSlowPathCall.cpp', u'Source/JavaScriptCore/ftl/FTLSlowPathCall.h', u'Source/JavaScriptCore/ftl/FTLState.h', u'Source/JavaScriptCore/jit/CCallHelpers.h', u'Source/JavaScriptCore/runtime/Executable.h']" exit_code: 1 Source/JavaScriptCore/ftl/FTLSlowPathCall.h:64: The parameter name "object" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 1 in 13 files If any of these errors are false positives, please file a bug against check-webkit-style.

Geoffrey Garen

Comment 6 2013-11-05 10:42:24 PST

Comment on attachment 216044 [details] the patch r=me

Filip Pizlo

Comment 7 2013-11-05 10:54:49 PST

Landed in http://trac.webkit.org/changeset/158681

Note You need to log in before you can comment on or make changes to this bug.