Bug 123758

Summary:

[Win] Use VersionStamper for official builds

Product:

WebKit

Reporter:

Brent Fulgham <bfulgham>

Component:

Tools / Tests

Assignee:

Brent Fulgham <bfulgham>

Status:

RESOLVED FIXED

Severity:

Normal

Keywords:

InRadar

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

All

Attachments:

Description	Flags
Patch	thorton: review+

Brent Fulgham

Reported 2013-11-04 15:01:46 PST

When we revised the build system for VS2010, the step that would run "VersionStamper" to set the shipping version number on the DLL was lost. This causes some internal stuff to break when we attempt to build for external users. This patch simply puts the missing command back into our post-build scripts so that the right thing happens when building an official release.

Attachments
Patch (2.54 KB, patch) 2013-11-04 15:05 PST, Brent Fulgham	thorton: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Brent Fulgham

Comment 1 2013-11-04 15:01:58 PST

<rdar://problem/15373550>

Brent Fulgham

Comment 2 2013-11-04 15:05:59 PST

Created attachment 215957 [details] Patch

Brent Fulgham

Comment 3 2013-11-04 15:24:37 PST

Committed r158602: <http://trac.webkit.org/changeset/158602>

Note You need to log in before you can comment on or make changes to this bug.