Bug 123737 (code)

Summary:

[Texmap] Removing of a redundant code

Product:

WebKit

Reporter:

Przemyslaw Szymanski <p.szymanski3>

Component:

Layout and Rendering

Assignee:

Keith Miller <keith_miller>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cmarcelo, commit-queue, keith_miller, kondapallykalyan, luiz, noam, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Redundant code	noam: review+, noam: commit-queue-
Redundant code	none

Przemyslaw Szymanski

Reported 2013-11-04 04:39:23 PST

After few refactor patches it is an unused code which can be removed

Attachments
Redundant code (2.26 KB, patch) 2013-11-04 04:44 PST, Przemyslaw Szymanski	noam: review+ noam: commit-queue-	Details Formatted Diff Diff
Redundant code (2.28 KB, patch) 2013-11-04 05:42 PST, Przemyslaw Szymanski	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Przemyslaw Szymanski

Comment 1 2013-11-04 04:44:30 PST

Created attachment 215912 [details] Redundant code

Noam Rosenthal

Comment 2 2013-11-04 05:04:28 PST

Comment on attachment 215912 [details] Redundant code View in context: https://bugs.webkit.org/attachment.cgi?id=215912&action=review > Source/WebCore/ChangeLog:3 > + [Texmap] Removing a redundant code Remove redundant calls in CoordinatedGraphicsScene > Source/WebCore/ChangeLog:8 > + It is some unused code left after few refactoring patches. It is -> Removing

Przemyslaw Szymanski

Comment 3 2013-11-04 05:42:42 PST

Created attachment 215914 [details] Redundant code

Przemyslaw Szymanski

Comment 4 2013-11-04 05:43:49 PST

(In reply to comment #2) > (From update of attachment 215912 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=215912&action=review > > > Source/WebCore/ChangeLog:3 > > + [Texmap] Removing a redundant code > > Remove redundant calls in CoordinatedGraphicsScene > > > Source/WebCore/ChangeLog:8 > > + It is some unused code left after few refactoring patches. > > It is -> Removing Thank you for your review. Changes updated

WebKit Commit Bot

Comment 5 2013-11-04 06:56:29 PST

Comment on attachment 215914 [details] Redundant code Clearing flags on attachment: 215914 Committed r158574: <http://trac.webkit.org/changeset/158574>

WebKit Commit Bot

Comment 6 2013-11-04 06:56:31 PST

All reviewed patches have been landed. Closing bug.

Keith Miller

Comment 7 2019-09-25 19:33:27 PDT

Reopening to attach new patch.

Keith Miller

Comment 8 2019-09-25 20:43:06 PDT

Ugh, WebKit-patch freaked out and reopened this... sorry for the spam.

Radar WebKit Bug Importer

Comment 9 2019-09-25 20:44:18 PDT

<rdar://problem/55730145>

Note You need to log in before you can comment on or make changes to this bug.