Bug 123725 – Use RenderAncestorIterator in a couple of places.

• Component: Layout and Rendering
• Status: RESOLVED FIXED

[Andreas Kling]

Use RenderAncestorIterator in a couple of places.

[Andreas Kling]

Created attachment 215897 [details]
Patch

[Antti Koivisto]

Comment on attachment 215897 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=215897&action=review

> Source/WebCore/rendering/RenderRegion.cpp:405
> +    if (auto closestFlowThreadAncestor = ancestorsOfType<RenderNamedFlowThread>(*this).first()) {
> +        m_parentNamedFlowThread = &*closestFlowThreadAncestor;
> +        // Do not take into account a region that links a flow with itself. The dependency
> +        // cannot change, so it is not worth adding it to the list.
> +        if (m_flowThread == m_parentNamedFlowThread)
> +            m_flowThread = nullptr;
> +    } else
> +        m_parentNamedFlowThread = nullptr;
>  }

I would reverse the test and do early return in the else case.

[Andreas Kling]

Committed r158611: <http://trac.webkit.org/changeset/158611>