Summary: | Use RenderAncestorIterator in a couple of places. | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Andreas Kling <kling> | ||||
Component: | Layout and Rendering | Assignee: | Andreas Kling <kling> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | kling, koivisto | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Andreas Kling
2013-11-04 01:37:48 PST
Created attachment 215897 [details]
Patch
Comment on attachment 215897 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=215897&action=review > Source/WebCore/rendering/RenderRegion.cpp:405 > + if (auto closestFlowThreadAncestor = ancestorsOfType<RenderNamedFlowThread>(*this).first()) { > + m_parentNamedFlowThread = &*closestFlowThreadAncestor; > + // Do not take into account a region that links a flow with itself. The dependency > + // cannot change, so it is not worth adding it to the list. > + if (m_flowThread == m_parentNamedFlowThread) > + m_flowThread = nullptr; > + } else > + m_parentNamedFlowThread = nullptr; > } I would reverse the test and do early return in the else case. Committed r158611: <http://trac.webkit.org/changeset/158611> |