Bug 123718

Summary: Add an ancestor renderer iterator.
Product: WebKit Reporter: Andreas Kling <kling>
Component: Layout and RenderingAssignee: Andreas Kling <kling>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc, glenn, kling, koivisto, kondapallykalyan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch koivisto: review+

Andreas Kling
Reported 2013-11-03 18:46:50 PST
We should have ancestorsOfType<RenderFoo>() iterators, too.
Attachments
Patch (28.28 KB, patch)
2013-11-03 19:11 PST, Andreas Kling 		koivisto: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Andreas Kling
Comment 1 2013-11-03 19:11:11 PST
Created attachment 215884 [details] Patch
WebKit Commit Bot
Comment 2 2013-11-03 19:14:12 PST
Attachment 215884 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/GNUmakefile.list.am', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj', u'Source/WebCore/WebCore.xcodeproj/project.pbxproj', u'Source/WebCore/rendering/RenderAncestorIterator.h', u'Source/WebCore/rendering/RenderBlock.h', u'Source/WebCore/rendering/RenderBlockFlow.cpp', u'Source/WebCore/rendering/RenderBlockFlow.h', u'Source/WebCore/rendering/RenderBox.cpp', u'Source/WebCore/rendering/RenderFrameSet.cpp', u'Source/WebCore/rendering/RenderFrameSet.h', u'Source/WebCore/rendering/RenderIterator.h', u'Source/WebCore/rendering/RenderTextFragment.cpp', u'Source/WebCore/rendering/RenderTextFragment.h']" exit_code: 1 Source/WebCore/rendering/RenderIterator.h:266: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 14 files If any of these errors are false positives, please file a bug against check-webkit-style.
Andreas Kling
Comment 3 2013-11-04 00:44:29 PST
Committed r158561: <http://trac.webkit.org/changeset/158561>
Note You need to log in before you can comment on or make changes to this bug.