Summary: | Switch createContextualFragment to element iterator | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Antti Koivisto <koivisto> | ||||||
Component: | DOM | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | cdumez, kling | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Antti Koivisto
2013-11-03 04:26:56 PST
Created attachment 215865 [details]
patch
Created attachment 215866 [details]
better patch
Comment on attachment 215866 [details] better patch View in context: https://bugs.webkit.org/attachment.cgi?id=215866&action=review r=me > Source/WebCore/editing/FrameSelection.cpp:1967 > + if (!contentDocument) > + continue; This looks new. Sneaky. Comment on attachment 215866 [details] better patch View in context: https://bugs.webkit.org/attachment.cgi?id=215866&action=review > Source/WebCore/editing/markup.cpp:913 > + collectElementsToRemoveFromFragment(element); This statement has no effect as the result value is being ignored. Comment on attachment 215866 [details] better patch View in context: https://bugs.webkit.org/attachment.cgi?id=215866&action=review >> Source/WebCore/editing/markup.cpp:913 >> + collectElementsToRemoveFromFragment(element); > > This statement has no effect as the result value is being ignored. Good catch! (In reply to comment #6) > Comment on attachment 215866 [details] > better patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=215866&action=review > > >> Source/WebCore/editing/markup.cpp:913 > >> + collectElementsToRemoveFromFragment(element); > > > > This statement has no effect as the result value is being ignored. > > Good catch! The thing is that I am not sure it is actually possible to have an <html> here. I have been trying to test the problem but I cannot get createFragmentForInnerOuterHTML() to return an <html> as first child in the DocumentFragment, despite the input having an <html> tag: http://jsfiddle.net/2qevwvs3/8/ |