Bug 123699

Summary: [CSSRegions] Use auto keyword to clean-up for loops
Product: WebKit Reporter: Mihnea Ovidenie <mihnea>
Component: CSSAssignee: Mihnea Ovidenie <mihnea>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc, glenn, kangil.han, kondapallykalyan, WebkitBugTracker
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Mihnea Ovidenie
Reported 2013-11-03 01:16:06 PST
Start using auto keyword in for loops instead of long iterators.
Attachments
Patch (41.18 KB, patch)
2013-11-03 01:22 PST, Mihnea Ovidenie 		no flags
DetailsFormatted DiffDiff
Patch for landing (42.46 KB, patch)
2013-11-03 23:56 PST, Mihnea Ovidenie 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Mihnea Ovidenie
Comment 1 2013-11-03 01:22:01 PST
Created attachment 215853 [details] Patch
Anders Carlsson
Comment 2 2013-11-03 07:17:53 PST
Comment on attachment 215853 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=215853&action=review > Source/WebCore/rendering/RenderRegion.cpp:538 > + for (auto iter = m_renderObjectRegionStyle.begin(), end = m_renderObjectRegionStyle.end(); iter != end; ++iter) { I think you should change the other loops to have the end iterator in a local variable as well, since you're changing them anyway.
Mihnea Ovidenie
Comment 3 2013-11-03 07:58:59 PST
(In reply to comment #2) > (From update of attachment 215853 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=215853&action=review > > > Source/WebCore/rendering/RenderRegion.cpp:538 > > + for (auto iter = m_renderObjectRegionStyle.begin(), end = m_renderObjectRegionStyle.end(); iter != end; ++iter) { > > I think you should change the other loops to have the end iterator in a local variable as well, since you're changing them anyway. Sure, thanks for the review.
Mihnea Ovidenie
Comment 4 2013-11-03 23:56:47 PST
Created attachment 215891 [details] Patch for landing
WebKit Commit Bot
Comment 5 2013-11-04 00:26:09 PST
Comment on attachment 215891 [details] Patch for landing Clearing flags on attachment: 215891 Committed r158559: <http://trac.webkit.org/changeset/158559>
WebKit Commit Bot
Comment 6 2013-11-04 00:26:11 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.