Summary: | [CSSRegions] Use auto keyword to clean-up for loops | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Mihnea Ovidenie <mihnea> | ||||||
Component: | CSS | Assignee: | Mihnea Ovidenie <mihnea> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | commit-queue, esprehn+autocc, glenn, kangil.han, kondapallykalyan, WebkitBugTracker | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Mihnea Ovidenie
2013-11-03 01:16:06 PST
Created attachment 215853 [details]
Patch
Comment on attachment 215853 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=215853&action=review > Source/WebCore/rendering/RenderRegion.cpp:538 > + for (auto iter = m_renderObjectRegionStyle.begin(), end = m_renderObjectRegionStyle.end(); iter != end; ++iter) { I think you should change the other loops to have the end iterator in a local variable as well, since you're changing them anyway. (In reply to comment #2) > (From update of attachment 215853 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=215853&action=review > > > Source/WebCore/rendering/RenderRegion.cpp:538 > > + for (auto iter = m_renderObjectRegionStyle.begin(), end = m_renderObjectRegionStyle.end(); iter != end; ++iter) { > > I think you should change the other loops to have the end iterator in a local variable as well, since you're changing them anyway. Sure, thanks for the review. Created attachment 215891 [details]
Patch for landing
Comment on attachment 215891 [details] Patch for landing Clearing flags on attachment: 215891 Committed r158559: <http://trac.webkit.org/changeset/158559> All reviewed patches have been landed. Closing bug. |