Summary: | Cleanup OpenTypeUtilities | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Patrick R. Gansterer <paroga> | ||||
Component: | New Bugs | Assignee: | Patrick R. Gansterer <paroga> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | commit-queue | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Patrick R. Gansterer
2013-11-02 14:07:48 PDT
Created attachment 215831 [details]
Patch
Comment on attachment 215831 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=215831&action=review Looks OK. > Source/WebCore/ChangeLog:3 > + Cleanup OpenTypeUtilities Cleanup is a noun. The verb is “clean up”. > Source/WebCore/platform/graphics/wince/FontCustomPlatformData.cpp:72 > std::unique_ptr<FontCustomPlatformData> createFontCustomPlatformData(const SharedBuffer* buffer) If you can assert that the buffer pointer is non-null, that’s a clue that the argument should be a reference instead of a pointer. Would be nice to change that at some point. Comment on attachment 215831 [details] Patch Clearing flags on attachment: 215831 Committed r158519: <http://trac.webkit.org/changeset/158519> All reviewed patches have been landed. Closing bug. |