| Summary: | Make AuthenticationClient a base class of ResourceHandle for all ports | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Patrick R. Gansterer <paroga> | ||||||
| Component: | New Bugs | Assignee: | Patrick R. Gansterer <paroga> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | darin, rbuis, rwlbuis | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Patrick R. Gansterer
2013-11-02 10:52:14 PDT
Created attachment 215816 [details]
Patch
Comment on attachment 215816 [details]
Patch
I’m not sure this is a good change. On the one hand, it’s nice to remove an unneeded #if, but on the other hand, I’m pretty sure that we’re now compiling dead code, since if anything was calling shouldUseCredentialStorage, we would not have compiled before. Implementing that function is not valuable. It would be better to not implement it rather than having code that is never called. Same for didReceiveAuthenticationChallenge. For the three virtual functions, I am unsure whether empty implementations are safe to have around.
Created attachment 215867 [details]
Patch
Comment on attachment 215867 [details]
Patch
This is obsolete in a number of ways, one of which being that ResourceHandle is no longer the sole network loading class.
It seems AuthenticationClient these days is a base class of ResourceHandle for all ports, should we close this? Sure, let's close it. |