Bug 123664

Summary: Generated color wheel displays incorrectly (regressed in r155567)
Product: WebKit Reporter: Antoine Quint <graouts>
Component: CanvasAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, fpizlo, ggaren, mark.lam, mhahnenberg, msaboff, nrotem, oliver, sam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Color wheel test case
none
the patch kling: review+

Description Antoine Quint 2013-11-02 06:46:56 PDT 
Created attachment 215807 [details]
Color wheel test case

The attached test case where we draw a color wheel programmatically using the CanvasRenderingContext2D API renders incorrectly on ToT where it used to work fine. Regressing shows that this rendered as expected as of r155565 and incorrectly with r155567, r155567 was untested but given it's a Windows-specific fix, it's likely that this regressed in http://trac.webkit.org/changeset/155567, a code change introduced to fix https://bugs.webkit.org/show_bug.cgi?id=121141.
Comment 1 Radar WebKit Bug Importer 2013-11-02 06:47:10 PDT 
<rdar://problem/15377184>
Comment 2 Filip Pizlo 2013-11-02 10:08:47 PDT 
Looks like a fun bug!
Comment 3 Filip Pizlo 2013-11-03 17:48:22 PST 
Yeah, it's obviously a miscompile in hsl2rgb().
Comment 4 Filip Pizlo 2013-11-03 18:12:33 PST 
Created attachment 215883 [details]
the patch
Comment 5 Filip Pizlo 2013-11-03 20:22:44 PST 
Landed in http://trac.webkit.org/changeset/158556