Bug 123657

Summary: Unprefix -webkit-text-decoration CSS properties
Product: WebKit Reporter: Myles C. Maxfield <mmaxfield>
Component: New BugsAssignee: Myles C. Maxfield <mmaxfield>
Status: RESOLVED DUPLICATE    
Severity: Normal CC: allan.jensen, buildbot, cdumez, commit-queue, dino, esprehn+autocc, glenn, gtk-ews, gyuyoung.kim, jonlee, kondapallykalyan, macpherson, menard, rakuco, rniwa, simon.fraser, syoichi, thorton, xan.lopez
Priority: P2 Keywords: WebExposed
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from webkit-ews-12 for mac-mountainlion-wk2
none
Archive of layout-test-results from webkit-ews-05 for mac-mountainlion none

Myles C. Maxfield
Reported 2013-11-01 22:21:42 PDT
Unprefix -webkit-text-decoration CSS properties
Attachments
Patch (182.21 KB, patch)
2013-11-01 23:49 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from webkit-ews-12 for mac-mountainlion-wk2 (242.73 KB, application/zip)
2013-11-02 00:41 PDT, Build Bot 		no flags
Details
Archive of layout-test-results from webkit-ews-05 for mac-mountainlion (265.86 KB, application/zip)
2013-11-02 02:36 PDT, Build Bot 		no flags
Details
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Myles C. Maxfield
Comment 1 2013-11-01 23:49:28 PDT
Created attachment 215799 [details] Patch
Build Bot
Comment 2 2013-11-02 00:41:19 PDT
Comment on attachment 215799 [details] Patch Attachment 215799 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/19658268 New failing tests: editing/style/remove-underline-across-paragraph-in-bold.html editing/execCommand/5190926.html editing/style/inline-style-extend-run.html editing/deleting/delete-line-break-before-underlined-content.html editing/deleting/merge-div-from-span-with-style.html editing/style/remove-nested-inline-styles.html editing/style/push-down-implicit-styles-around-list-mac.html editing/style/inline-style-container.html editing/execCommand/strikethroughSelection.html editing/pasteboard/insert-u-with-text-decoration-none.html editing/execCommand/toggle-style-2.html editing/pasteboard/5134759.html editing/style/push-down-implicit-styles-around-list-win.html editing/execCommand/remove-format-multiple-elements-win.html editing/style/remove-underline-across-paragraph.html editing/deleting/merge-paragraph-from-span-with-multiple-text-decoration.html editing/style/font-family-with-space.html editing/style/push-down-implicit-styles-mac.html editing/pasteboard/5075944.html editing/execCommand/remove-format-multiple-elements-mac.html editing/execCommand/toggle-styles.html editing/execCommand/query-text-decoration-with-typing-style.html editing/execCommand/inline-style-after-indentoutdent.html editing/execCommand/toggle-text-decorations.html editing/execCommand/use-css.html editing/deleting/merge-paragraph-from-span-with-style.html editing/style/push-down-inline-styles.html editing/execCommand/strikethrough-uses-strike-tag.html editing/deleting/deleting-line-break-preserves-underline-color.html editing/execCommand/remove-formatting.html
Build Bot
Comment 3 2013-11-02 00:41:23 PDT
Created attachment 215801 [details] Archive of layout-test-results from webkit-ews-12 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-12 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
kov's GTK+ EWS bot
Comment 4 2013-11-02 00:43:35 PDT
Comment on attachment 215799 [details] Patch Attachment 215799 [details] did not pass gtk-ews (gtk): Output: http://webkit-queues.appspot.com/results/19588239
Build Bot
Comment 5 2013-11-02 02:35:59 PDT
Comment on attachment 215799 [details] Patch Attachment 215799 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/19648250 New failing tests: editing/style/remove-underline-across-paragraph-in-bold.html editing/execCommand/5190926.html editing/style/inline-style-extend-run.html editing/deleting/delete-line-break-before-underlined-content.html editing/deleting/merge-div-from-span-with-style.html editing/style/remove-nested-inline-styles.html editing/style/push-down-implicit-styles-around-list-mac.html editing/style/inline-style-container.html editing/execCommand/strikethroughSelection.html editing/pasteboard/insert-u-with-text-decoration-none.html editing/execCommand/toggle-style-2.html editing/pasteboard/5134759.html editing/style/push-down-implicit-styles-around-list-win.html editing/execCommand/remove-format-multiple-elements-win.html editing/style/remove-underline-across-paragraph.html editing/deleting/merge-paragraph-from-span-with-multiple-text-decoration.html editing/style/font-family-with-space.html editing/style/push-down-implicit-styles-mac.html editing/pasteboard/5075944.html editing/execCommand/remove-format-multiple-elements-mac.html editing/execCommand/toggle-styles.html editing/execCommand/query-text-decoration-with-typing-style.html editing/execCommand/inline-style-after-indentoutdent.html editing/execCommand/toggle-text-decorations.html editing/execCommand/use-css.html editing/deleting/merge-paragraph-from-span-with-style.html editing/style/push-down-inline-styles.html editing/execCommand/strikethrough-uses-strike-tag.html editing/deleting/deleting-line-break-preserves-underline-color.html editing/execCommand/remove-formatting.html
Build Bot
Comment 6 2013-11-02 02:36:01 PDT
Created attachment 215803 [details] Archive of layout-test-results from webkit-ews-05 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-05 Port: mac-mountainlion Platform: Mac OS X 10.8.5
Ryosuke Niwa
Comment 7 2013-11-02 13:57:02 PDT
Why are we unprefixing these CSS properties? Have the specification reached CR state? Also, has this been announced on webkit-dev? Most importantly, does our implementation conform to the standards? Are we sure there aren't any bugs?
Jon Lee
Comment 8 2013-11-03 12:31:34 PST
Indeed the spec is at CR. It looks like a good portion of the spec is already implemented.
Jon Lee
Comment 9 2013-11-03 12:31:48 PST
Link to spec: http://www.w3.org/TR/css-text-decor-3/
Ryosuke Niwa
Comment 10 2013-11-03 12:33:26 PST
Is it the case that no WebKit port ever shipped these CSS properties prefixed? If not, then we need to keep both the prefixed and unprefixed properties.
Myles C. Maxfield
Comment 11 2014-01-20 16:27:55 PST
*** This bug has been marked as a duplicate of bug 127193 ***
Csaba Osztrogonác
Comment 12 2014-02-13 03:44:56 PST
Comment on attachment 215799 [details] Patch Cleared review? from attachment 215799 [details] so that this bug does not appear in http://webkit.org/pending-review. If you would like this patch reviewed, please attach it to a new bug (or re-open this bug before marking it for review again).
Note You need to log in before you can comment on or make changes to this bug.