Summary: | Removing MediaStreamTrackVector and MediaStreamSourceVector typedefs | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Thiago de Barros Lacerda <thiago.lacerda> | ||||||
Component: | WebCore Misc. | Assignee: | Thiago de Barros Lacerda <thiago.lacerda> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | commit-queue, eric.carlson | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | 123644 | ||||||||
Bug Blocks: | |||||||||
Attachments: |
|
Description
Thiago de Barros Lacerda
2013-11-01 16:58:45 PDT
Created attachment 215781 [details]
Patch
Comment on attachment 215781 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=215781&action=review This looks good, thanks for doing it! r=me, but it looks like it needs to be rebased so I listed a couple of drive-by changes you might make. > Source/WebCore/Modules/mediastream/MediaStream.cpp:137 > +void MediaStream::cloneMediaStreamTrackVector(Vector<RefPtr<MediaStreamTrack>>& destination, const Vector<RefPtr<MediaStreamTrack>>& origin) Nit: while you are here, can you change "origin" to "source"? > Source/WebCore/Modules/mediastream/MediaStream.cpp:219 > + for (Vector<RefPtr<MediaStreamTrack>>::iterator iter = m_audioTracks.begin(); iter != m_audioTracks.end(); ++iter) { Nit: while you are here, can you fix this to use "auto"? > Source/WebCore/Modules/mediastream/MediaStream.cpp:226 > + for (Vector<RefPtr<MediaStreamTrack>>::iterator iter = m_videoTracks.begin(); iter != m_videoTracks.end(); ++iter) { Ditto. > Source/WebCore/Modules/mediastream/MediaStream.cpp:236 > + for (Vector<RefPtr<MediaStreamTrack>>::iterator iter = m_audioTracks.begin(); iter != m_audioTracks.end(); ++iter) { Ditto. > Source/WebCore/Modules/mediastream/MediaStream.cpp:241 > + for (Vector<RefPtr<MediaStreamTrack>>::iterator iter = m_videoTracks.begin(); iter != m_videoTracks.end(); ++iter) { Ditto. > Source/WebCore/Modules/mediastream/UserMediaRequest.cpp:169 > + for (Vector<RefPtr<MediaStreamTrack>>::iterator iter = tracks.begin(); iter != tracks.end(); ++iter) Ditto. > Source/WebCore/Modules/mediastream/UserMediaRequest.cpp:173 > + for (Vector<RefPtr<MediaStreamTrack>>::iterator iter = tracks.begin(); iter != tracks.end(); ++iter) Ditto. (In reply to comment #2) > (From update of attachment 215781 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=215781&action=review > > This looks good, thanks for doing it! > > r=me, but it looks like it needs to be rebased so I listed a couple of drive-by changes you might make. > > > Source/WebCore/Modules/mediastream/MediaStream.cpp:137 > > +void MediaStream::cloneMediaStreamTrackVector(Vector<RefPtr<MediaStreamTrack>>& destination, const Vector<RefPtr<MediaStreamTrack>>& origin) > > Nit: while you are here, can you change "origin" to "source"? > > > Source/WebCore/Modules/mediastream/MediaStream.cpp:219 > > + for (Vector<RefPtr<MediaStreamTrack>>::iterator iter = m_audioTracks.begin(); iter != m_audioTracks.end(); ++iter) { > > Nit: while you are here, can you fix this to use "auto"? > > > Source/WebCore/Modules/mediastream/MediaStream.cpp:226 > > + for (Vector<RefPtr<MediaStreamTrack>>::iterator iter = m_videoTracks.begin(); iter != m_videoTracks.end(); ++iter) { > > Ditto. > > > Source/WebCore/Modules/mediastream/MediaStream.cpp:236 > > + for (Vector<RefPtr<MediaStreamTrack>>::iterator iter = m_audioTracks.begin(); iter != m_audioTracks.end(); ++iter) { > > Ditto. > > > Source/WebCore/Modules/mediastream/MediaStream.cpp:241 > > + for (Vector<RefPtr<MediaStreamTrack>>::iterator iter = m_videoTracks.begin(); iter != m_videoTracks.end(); ++iter) { > > Ditto. > > > Source/WebCore/Modules/mediastream/UserMediaRequest.cpp:169 > > + for (Vector<RefPtr<MediaStreamTrack>>::iterator iter = tracks.begin(); iter != tracks.end(); ++iter) > > Ditto. > > > Source/WebCore/Modules/mediastream/UserMediaRequest.cpp:173 > > + for (Vector<RefPtr<MediaStreamTrack>>::iterator iter = tracks.begin(); iter != tracks.end(); ++iter) > > Ditto. OK for all Created attachment 215791 [details]
Patch
Comment on attachment 215791 [details] Patch Clearing flags on attachment: 215791 Committed r158480: <http://trac.webkit.org/changeset/158480> All reviewed patches have been landed. Closing bug. |