Bug 123645

Summary: CSSAspectRatioValue construction helper should return PassRef.
Product: WebKit Reporter: Andreas Kling <kling>
Component: CSSAssignee: Andreas Kling <kling>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc, glenn, gyuyoung.kim, kling, macpherson, menard
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
darin: review+
Patch for landing
kling: commit-queue+
Patch for landing none

Andreas Kling
Reported 2013-11-01 15:58:06 PDT
CSSAspectRatioValue construction helper should return PassRef.
Attachments
Patch (1.64 KB, patch)
2013-11-01 15:58 PDT, Andreas Kling 		darin: review+
DetailsFormatted DiffDiff
Patch for landing (1.37 KB, patch)
2013-11-01 17:23 PDT, Andreas Kling 		kling: commit-queue+
DetailsFormatted DiffDiff
Patch for landing (1.37 KB, patch)
2013-11-01 17:29 PDT, Andreas Kling 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Andreas Kling
Comment 1 2013-11-01 15:58:47 PDT
Created attachment 215773 [details] Patch
Darin Adler
Comment 2 2013-11-01 16:14:21 PDT
Comment on attachment 215773 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=215773&action=review > Source/WebCore/ChangeLog:8 > + No new tests (OOPS!). OOPS!? No file list? > Source/WebCore/css/CSSAspectRatioValue.h:52 > + explicit CSSAspectRatioValue(float numeratorValue, float denominatorValue) Two arguments -- no need for explicit, which only affects things with one argument.
Andreas Kling
Comment 3 2013-11-01 16:15:54 PDT
(In reply to comment #2) > (From update of attachment 215773 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=215773&action=review > > > Source/WebCore/ChangeLog:8 > > + No new tests (OOPS!). > > OOPS!? > > No file list? > > > Source/WebCore/css/CSSAspectRatioValue.h:52 > > + explicit CSSAspectRatioValue(float numeratorValue, float denominatorValue) > > Two arguments -- no need for explicit, which only affects things with one argument. Urgh. Hardcore rush job. :|
Andreas Kling
Comment 4 2013-11-01 17:23:16 PDT
Created attachment 215783 [details] Patch for landing
Andreas Kling
Comment 5 2013-11-01 17:29:45 PDT
Created attachment 215784 [details] Patch for landing
WebKit Commit Bot
Comment 6 2013-11-01 18:01:33 PDT
Comment on attachment 215784 [details] Patch for landing Clearing flags on attachment: 215784 Committed r158469: <http://trac.webkit.org/changeset/158469>
WebKit Commit Bot
Comment 7 2013-11-01 18:01:36 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.