Bug 123645

Summary: CSSAspectRatioValue construction helper should return PassRef.
Product: WebKit Reporter: Andreas Kling <kling>
Component: CSSAssignee: Andreas Kling <kling>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc, glenn, gyuyoung.kim, kling, macpherson, menard
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
darin: review+
Patch for landing
kling: commit-queue+
Patch for landing none

Description Andreas Kling 2013-11-01 15:58:06 PDT 
CSSAspectRatioValue construction helper should return PassRef.
Comment 1 Andreas Kling 2013-11-01 15:58:47 PDT 
Created attachment 215773 [details]
Patch
Comment 2 Darin Adler 2013-11-01 16:14:21 PDT 
Comment on attachment 215773 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=215773&action=review

> Source/WebCore/ChangeLog:8
> +        No new tests (OOPS!).

OOPS!?

No file list?

> Source/WebCore/css/CSSAspectRatioValue.h:52
> +    explicit CSSAspectRatioValue(float numeratorValue, float denominatorValue)

Two arguments -- no need for explicit, which only affects things with one argument.
Comment 3 Andreas Kling 2013-11-01 16:15:54 PDT 
(In reply to comment #2)
> (From update of attachment 215773 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=215773&action=review
> 
> > Source/WebCore/ChangeLog:8
> > +        No new tests (OOPS!).
> 
> OOPS!?
> 
> No file list?
> 
> > Source/WebCore/css/CSSAspectRatioValue.h:52
> > +    explicit CSSAspectRatioValue(float numeratorValue, float denominatorValue)
> 
> Two arguments -- no need for explicit, which only affects things with one argument.

Urgh. Hardcore rush job. :|
Comment 4 Andreas Kling 2013-11-01 17:23:16 PDT 
Created attachment 215783 [details]
Patch for landing
Comment 5 Andreas Kling 2013-11-01 17:29:45 PDT 
Created attachment 215784 [details]
Patch for landing
Comment 6 WebKit Commit Bot 2013-11-01 18:01:33 PDT 
Comment on attachment 215784 [details]
Patch for landing

Clearing flags on attachment: 215784

Committed r158469: <http://trac.webkit.org/changeset/158469>
Comment 7 WebKit Commit Bot 2013-11-01 18:01:36 PDT 
All reviewed patches have been landed.  Closing bug.