Bug 123635

Summary: Move CF/Mac WTF String implementations down into WTF
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: Web Template FrameworkAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cmarcelo, commit-queue, joepeck
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
[PATCH] Proposed Fix (for bots)
none
[PATCH] For Windows Bots none

Joseph Pecoraro
Reported 2013-11-01 14:05:41 PDT
Some WTF String functions were implemented in WebCore even though they were defined in WTF headers. I want to move the implementations down into WTF, and potentially use them in JavaScriptCore.
Attachments
[PATCH] Proposed Fix (for bots) (28.42 KB, patch)
2013-11-01 14:08 PDT, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
[PATCH] For Windows Bots (28.42 KB, patch)
2013-11-01 17:34 PDT, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Joseph Pecoraro
Comment 1 2013-11-01 14:08:04 PDT
Created attachment 215760 [details] [PATCH] Proposed Fix (for bots) I attempted to update Windows projects, I don't know if it will succeed.
WebKit Commit Bot
Comment 2 2013-11-01 14:09:30 PDT
Attachment 215760 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WTF/ChangeLog', u'Source/WTF/WTF.vcxproj/WTF.vcxproj', u'Source/WTF/WTF.vcxproj/WTF.vcxproj.filters', u'Source/WTF/WTF.xcodeproj/project.pbxproj', u'Source/WTF/wtf/text/AtomicString.h', u'Source/WTF/wtf/text/StringImpl.h', u'Source/WTF/wtf/text/WTFString.h', u'Source/WTF/wtf/text/cf/AtomicStringCF.cpp', u'Source/WTF/wtf/text/cf/StringCF.cpp', u'Source/WTF/wtf/text/cf/StringImplCF.cpp', u'Source/WTF/wtf/text/mac/StringImplMac.mm', u'Source/WTF/wtf/text/mac/StringMac.mm', u'Source/WebCore/ChangeLog', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj.filters', u'Source/WebCore/WebCore.xcodeproj/project.pbxproj', u'Source/WebCore/platform/text/cf/AtomicStringCF.cpp', u'Source/WebCore/platform/text/cf/StringCF.cpp', u'Source/WebCore/platform/text/cf/StringImplCF.cpp', u'Source/WebCore/platform/text/mac/StringImplMac.mm', u'Source/WebCore/platform/text/mac/StringMac.mm']" exit_code: 1 Source/WTF/wtf/text/WTFString.h:412: Use 0 or null instead of NULL (even in *comments*). [readability/null] [4] Source/WTF/wtf/text/cf/StringCF.cpp:37: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] Source/WTF/wtf/text/cf/StringImplCF.cpp:49: Code inside a namespace should not be indented. [whitespace/indent] [4] Total errors found: 3 in 13 files If any of these errors are false positives, please file a bug against check-webkit-style.
Joseph Pecoraro
Comment 3 2013-11-01 17:34:11 PDT
Heh, unfortunately the bot I care about couldn't apply the patch. That is probably a bad sign.
Joseph Pecoraro
Comment 4 2013-11-01 17:34:33 PDT
Created attachment 215785 [details] [PATCH] For Windows Bots
WebKit Commit Bot
Comment 5 2013-11-01 17:35:32 PDT
Attachment 215785 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WTF/ChangeLog', u'Source/WTF/WTF.vcxproj/WTF.vcxproj', u'Source/WTF/WTF.vcxproj/WTF.vcxproj.filters', u'Source/WTF/WTF.xcodeproj/project.pbxproj', u'Source/WTF/wtf/text/AtomicString.h', u'Source/WTF/wtf/text/StringImpl.h', u'Source/WTF/wtf/text/WTFString.h', u'Source/WTF/wtf/text/cf/AtomicStringCF.cpp', u'Source/WTF/wtf/text/cf/StringCF.cpp', u'Source/WTF/wtf/text/cf/StringImplCF.cpp', u'Source/WTF/wtf/text/mac/StringImplMac.mm', u'Source/WTF/wtf/text/mac/StringMac.mm', u'Source/WebCore/ChangeLog', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj.filters', u'Source/WebCore/WebCore.xcodeproj/project.pbxproj', u'Source/WebCore/platform/text/cf/AtomicStringCF.cpp', u'Source/WebCore/platform/text/cf/StringCF.cpp', u'Source/WebCore/platform/text/cf/StringImplCF.cpp', u'Source/WebCore/platform/text/mac/StringImplMac.mm', u'Source/WebCore/platform/text/mac/StringMac.mm']" exit_code: 1 Source/WTF/wtf/text/WTFString.h:412: Use 0 or null instead of NULL (even in *comments*). [readability/null] [4] Source/WTF/wtf/text/cf/StringCF.cpp:37: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] Source/WTF/wtf/text/cf/StringImplCF.cpp:49: Code inside a namespace should not be indented. [whitespace/indent] [4] Total errors found: 3 in 13 files If any of these errors are false positives, please file a bug against check-webkit-style.
Joseph Pecoraro
Comment 6 2013-11-01 17:56:43 PDT
Comment on attachment 215785 [details] [PATCH] For Windows Bots Going to CQ+ and check bots. I got a sanity check from Windows developers.
WebKit Commit Bot
Comment 7 2013-11-01 18:20:52 PDT
Comment on attachment 215760 [details] [PATCH] Proposed Fix (for bots) Clearing flags on attachment: 215760 Committed r158471: <http://trac.webkit.org/changeset/158471>
WebKit Commit Bot
Comment 8 2013-11-01 18:20:54 PDT
All reviewed patches have been landed. Closing bug.
Joseph Pecoraro
Comment 9 2013-11-01 18:48:00 PDT
Broke windows. Attempt at a build fix with: <http://trac.webkit.org/changeset/158475>
Joseph Pecoraro
Comment 10 2013-11-01 19:07:39 PDT
And another, I missed a few includes: <http://trac.webkit.org/changeset/158479>
Joseph Pecoraro
Comment 11 2013-11-01 20:18:28 PDT
Bots look good now!
Note You need to log in before you can comment on or make changes to this bug.