Bug 123626

Summary: [iOS] Make some headers Private
Product: WebKit Reporter: Andy Estes <aestes>
Component: New BugsAssignee: Andy Estes <aestes>
Status: RESOLVED FIXED    
Severity: Normal CC: kling
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
[iOS] Make some headers Private
none
[iOS] Make some headers Private kling: review+

Andy Estes
Reported 2013-11-01 11:31:33 PDT
[iOS] Make some headers Private
Attachments
[iOS] Make some headers Private (13.21 KB, patch)
2013-11-01 11:32 PDT, Andy Estes 		no flags
DetailsFormatted DiffDiff
[iOS] Make some headers Private (15.03 KB, patch)
2013-11-01 13:55 PDT, Andy Estes 		kling: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Andy Estes
Comment 1 2013-11-01 11:32:52 PDT
Created attachment 215745 [details] [iOS] Make some headers Private
Andy Estes
Comment 2 2013-11-01 11:36:23 PDT
Committed r158443: <http://trac.webkit.org/changeset/158443>
Andy Estes
Comment 3 2013-11-01 12:11:04 PDT
Reverted in https://trac.webkit.org/r158446 since this broke the build.
Andy Estes
Comment 4 2013-11-01 13:55:50 PDT
Created attachment 215757 [details] [iOS] Make some headers Private
Andreas Kling
Comment 5 2013-11-01 14:00:07 PDT
Comment on attachment 215757 [details] [iOS] Make some headers Private rs=me
Andreas Kling
Comment 6 2013-11-01 14:01:05 PDT
Comment on attachment 215757 [details] [iOS] Make some headers Private View in context: https://bugs.webkit.org/attachment.cgi?id=215757&action=review > Source/WebKit/mac/Configurations/WebKit.xcconfig:30 > +EXCLUDED_SOURCE_FILE_NAMES_macosx = *IOS.mm WebKit.iOS.exp MemoryMeasure.h WebGeolocationCoreLocationProvider.h WebGeolocationProviderIOS.h WebNSStringDrawing.h WebNSStringExtrasIOS.h WebNSStringExtrasIPhone.h WebUIKitSupport.h WebCaretChangeListener.h WebFixedPositionContent.h WebFrameIOS.h WebFrameIPhone.h WebGeolocationPrivate.h WebMIMETypeRegistry.h WebSelectionRect.h WebVisiblePosition.h WebUIKitDelegate.h WebPDFViewIOS.h WebPDFViewIPhone.h WebPDFViewPlaceholder.h; This doesn't feel very future-proof.
Andreas Kling
Comment 7 2013-11-01 14:01:06 PDT
Comment on attachment 215757 [details] [iOS] Make some headers Private View in context: https://bugs.webkit.org/attachment.cgi?id=215757&action=review > Source/WebKit/mac/Configurations/WebKit.xcconfig:30 > +EXCLUDED_SOURCE_FILE_NAMES_macosx = *IOS.mm WebKit.iOS.exp MemoryMeasure.h WebGeolocationCoreLocationProvider.h WebGeolocationProviderIOS.h WebNSStringDrawing.h WebNSStringExtrasIOS.h WebNSStringExtrasIPhone.h WebUIKitSupport.h WebCaretChangeListener.h WebFixedPositionContent.h WebFrameIOS.h WebFrameIPhone.h WebGeolocationPrivate.h WebMIMETypeRegistry.h WebSelectionRect.h WebVisiblePosition.h WebUIKitDelegate.h WebPDFViewIOS.h WebPDFViewIPhone.h WebPDFViewPlaceholder.h; This doesn't feel very future-proof.
Andy Estes
Comment 8 2013-11-01 14:05:25 PDT
Committed r158454: <http://trac.webkit.org/changeset/158454>
Note You need to log in before you can comment on or make changes to this bug.