Bug 123620

Summary: Explicitly initialize RefCounted base class in MediaStreamTrack's constructors
Product: WebKit Reporter: Nick Diego Yamane (diegoyam) <nick.diego>
Component: New BugsAssignee: Nick Diego Yamane (diegoyam) <nick.diego>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric.carlson, glenn, hta, jer.noble, tommyw
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

Nick Diego Yamane (diegoyam)
Reported 2013-11-01 10:23:49 PDT
Explicitly initialize RefCounted base class in MediaStreamTrack's constructors
Attachments
Patch (1.85 KB, patch)
2013-11-01 10:26 PDT, Nick Diego Yamane (diegoyam) 		no flags
DetailsFormatted DiffDiff
Patch (1.85 KB, patch)
2013-11-01 10:46 PDT, Nick Diego Yamane (diegoyam) 		no flags
DetailsFormatted DiffDiff
Patch (1.86 KB, patch)
2013-11-01 10:53 PDT, Nick Diego Yamane (diegoyam) 		no flags
DetailsFormatted DiffDiff
Patch (1.51 KB, patch)
2013-11-01 11:18 PDT, Nick Diego Yamane (diegoyam) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Nick Diego Yamane (diegoyam)
Comment 1 2013-11-01 10:26:38 PDT
Created attachment 215737 [details] Patch
Andreas Kling
Comment 2 2013-11-01 10:43:48 PDT
Comment on attachment 215737 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=215737&action=review r=me > Source/WebCore/ChangeLog:8 > + No new needed. No new what needed?
Nick Diego Yamane (diegoyam)
Comment 3 2013-11-01 10:46:56 PDT
Created attachment 215741 [details] Patch
Nick Diego Yamane (diegoyam)
Comment 4 2013-11-01 10:53:07 PDT
Created attachment 215742 [details] Patch
WebKit Commit Bot
Comment 5 2013-11-01 11:02:08 PDT
Comment on attachment 215742 [details] Patch Rejecting attachment 215742 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 215742, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: cwd: /Volumes/Data/EWS/WebKit Parsed 2 diffs from patch file(s). patching file Source/WebCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebCore/Modules/mediastream/MediaStreamTrack.cpp Hunk #2 FAILED at 67. 1 out of 2 hunks FAILED -- saving rejects to file Source/WebCore/Modules/mediastream/MediaStreamTrack.cpp.rej Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Andreas Kling']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.appspot.com/results/19688044
Nick Diego Yamane (diegoyam)
Comment 6 2013-11-01 11:18:32 PDT
Created attachment 215743 [details] Patch
WebKit Commit Bot
Comment 7 2013-11-01 11:28:15 PDT
Comment on attachment 215743 [details] Patch Clearing flags on attachment: 215743 Committed r158442: <http://trac.webkit.org/changeset/158442>
WebKit Commit Bot
Comment 8 2013-11-01 11:28:17 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.