|Summary:||Move duplicate code in TrackPrivate classes to a common base class|
|Product:||WebKit||Reporter:||Brendan Long <b.long>|
|Component:||Media||Assignee:||Brendan Long <b.long>|
|Severity:||Normal||CC:||commit-queue, darin, eric.carlson, esprehn+autocc, glenn, gustavo, gyuyoung.kim, jer.noble, menard, mrobinson, pnormand|
|Version:||528+ (Nightly build)|
Description Brendan Long 2013-11-01 10:09:54 PDT
Move duplicate code in TrackPrivate classes to a common base class
Comment 1 Brendan Long 2013-11-01 10:19:40 PDT
Created attachment 215735 [details] Patch Question: Was it correct to move the `WTF_MAKE_NONCOPYABLE(VideoTrackPrivate); WTF_MAKE_FAST_ALLOCATED;` to TrackPrivateBase, or does that need to stay in the derived classes?
Comment 2 Darin Adler 2013-11-01 11:34:25 PDT
(In reply to comment #1) > Question: Was it correct to move the `WTF_MAKE_NONCOPYABLE(VideoTrackPrivate); WTF_MAKE_FAST_ALLOCATED;` to TrackPrivateBase, or does that need to stay in the derived classes? WTF_MAKE_NONCOPYABLE can just be in the base class. I don’t know the answer about WTF_MAKE_FAST_ALLOCATED.
Comment 3 Philippe Normand 2013-11-04 06:26:41 PST
The patch looks good to me provided the question about WTF_MAKE_FAST_ALLOCATED gets an answer :) Looking at the definition of the macro in Source/WTF/wtf/FastMalloc.h it seems to me that it can be used in the base class and that would be it. It'd be better to confirm that with someone more familiar with that though.
Comment 4 WebKit Commit Bot 2013-11-04 17:35:35 PST
Comment on attachment 215735 [details] Patch Clearing flags on attachment: 215735 Committed r158626: <http://trac.webkit.org/changeset/158626>
Comment 5 WebKit Commit Bot 2013-11-04 17:35:37 PST
All reviewed patches have been landed. Closing bug.