Bug 123601 – [GTK] invalid use of incomplete type 'class WTF::PassOwnPtr<WTF::Vector<unsigned char> >'

• Component: WebKitGTK
• Status: RESOLVED FIXED

[Emilio Pozuelo Monfort]

Building webkitgtk 2.3.1 with GCC 4.8 after applying the fix in bug 123502 I get:

../Source/WebKit2/WebProcess/Plugins/Netscape/NetscapePluginStream.cpp: In member function 'void WebKit::NetscapePluginStream::deliverData(const char*, int)':
../Source/WebKit2/WebProcess/Plugins/Netscape/NetscapePluginStream.cpp:189:58: error: invalid use of incomplete type 'class WTF::PassOwnPtr<WTF::Vector<unsigned char> >'
             m_deliveryData = adoptPtr(new Vector<uint8_t>);
                                                          ^
In file included from ../Source/WebCore/platform/FileSystem.h:34:0,
                 from ./DerivedSources/WebKit2/include/WebCore/FileSystem.h:1,
                 from ../Source/WebKit2/WebProcess/Plugins/Netscape/NetscapePluginStream.h:31,
                 from ../Source/WebKit2/WebProcess/Plugins/Netscape/NetscapePluginStream.cpp:27:
../Source/WTF/wtf/Forward.h:30:28: error: declaration of 'class WTF::PassOwnPtr<WTF::Vector<unsigned char> >'
 template<typename T> class PassOwnPtr;
                            ^
make[2]: *** [Source/WebKit2/WebProcess/Plugins/Netscape/Programs_WebKitPluginProcess-NetscapePluginStream.o] Error 1

[Zan Dobersek]

Created attachment 215726 [details]
Speculative fix

This patch just includes the PassOwnPtr.h header -- can you try it out and report back if it fixes the problem?

If the problem persists or you don't have the time to test the patch out, please attach the config.log file so someone else can try to replicate the problem and provide further fixes.

Thanks!

[Emilio Pozuelo Monfort]

Created attachment 215730 [details]
config.log

[Emilio Pozuelo Monfort]

(In reply to comment #1)
> Created an attachment (id=215726) [details]
> Speculative fix
> 
> This patch just includes the PassOwnPtr.h header -- can you try it out and report back if it fixes the problem?

Sure, will start a build later today and report back.

> If the problem persists or you don't have the time to test the patch out, please attach the config.log file so someone else can try to replicate the problem and provide further fixes.

Attached just in case. Will do so from the start for future reports.

[Emilio Pozuelo Monfort]

(In reply to comment #3)
> (In reply to comment #1)
> > Created an attachment (id=215726) [details] [details]
> > Speculative fix
> > 
> > This patch just includes the PassOwnPtr.h header -- can you try it out and report back if it fixes the problem?
> 
> Sure, will start a build later today and report back.

The patch worked nicely!

[Zan Dobersek]

Created attachment 215805 [details]
Patch

[Zan Dobersek]

Comment on attachment 215805 [details]
Patch

Clearing flags on attachment: 215805

Committed r158487: <http://trac.webkit.org/changeset/158487>

[Zan Dobersek]

All reviewed patches have been landed.  Closing bug.