Summary: | Remove #include from test input of the *Messages.in processing scripts | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Gergő Balogh <gbalogh.u-szeged> | ||||||
Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | andersca, benjamin, commit-queue, darin, kling, ossy | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Gergő Balogh
2013-10-31 02:02:06 PDT
Created attachment 215633 [details]
patch
Won't this break the unit test? No, the parser.py do not process #include lines only #if and #endif lines. (In reply to comment #2) > Won't this break the unit test? The title of the bug is misleading, because there aren't any includes in *.messages.in files. The only useless include is in the example input in messages_unittest.py. It can be safely removed, because parser.py doesn't process includes at all, as you mentioned. The patch looks good to me, but please fix the misleading title. Created attachment 216571 [details]
patch
Only the patch description changed.
LGTM, but it needs a WK2 owner review. Comment on attachment 216571 [details] patch Clearing flags on attachment: 216571 Committed r159075: <http://trac.webkit.org/changeset/159075> All reviewed patches have been landed. Closing bug. |