Bug 123563

Summary: Remove #include from test input of the *Messages.in processing scripts
Product: WebKit Reporter: Gergő Balogh <gbalogh.u-szeged>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, benjamin, commit-queue, darin, kling, ossy
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
none
patch none

Gergő Balogh
Reported 2013-10-31 02:02:06 PDT
There is some #include line left in the *.in files which could be safely removed.
Attachments
patch (1.15 KB, patch)
2013-10-31 02:07 PDT, Gergő Balogh 		no flags
DetailsFormatted DiffDiff
patch (1.14 KB, patch)
2013-11-11 07:18 PST, Gergő Balogh 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Gergő Balogh
Comment 1 2013-10-31 02:07:58 PDT
Created attachment 215633 [details] patch
Anders Carlsson
Comment 2 2013-10-31 07:23:33 PDT
Won't this break the unit test?
Gergő Balogh
Comment 3 2013-10-31 12:14:27 PDT
No, the parser.py do not process #include lines only #if and #endif lines. (In reply to comment #2) > Won't this break the unit test?
Csaba Osztrogonác
Comment 4 2013-11-04 02:36:53 PST
The title of the bug is misleading, because there aren't any includes in *.messages.in files. The only useless include is in the example input in messages_unittest.py. It can be safely removed, because parser.py doesn't process includes at all, as you mentioned. The patch looks good to me, but please fix the misleading title.
Gergő Balogh
Comment 5 2013-11-11 07:18:59 PST
Created attachment 216571 [details] patch Only the patch description changed.
Csaba Osztrogonác
Comment 6 2013-11-11 07:20:48 PST
LGTM, but it needs a WK2 owner review.
WebKit Commit Bot
Comment 7 2013-11-11 15:27:16 PST
Comment on attachment 216571 [details] patch Clearing flags on attachment: 216571 Committed r159075: <http://trac.webkit.org/changeset/159075>
WebKit Commit Bot
Comment 8 2013-11-11 15:27:18 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.