Bug 123555

Summary:

REGRESSION(r158311): media/media-fragments/TC0054.html and TC0061.html hit assertions

Product:

WebKit

Reporter:

Ryosuke Niwa <rniwa>

Component:

Media

Assignee:

Eric Carlson <eric.carlson>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, eric.carlson, esprehn+autocc, glenn, gyuyoung.kim, jer.noble

Priority:

Keywords:

LayoutTestFailure

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Proposed patch	none
Updated patch	none

Description Ryosuke Niwa 2013-10-30 21:50:33 PDT

http://webkit-test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=media%2Fmedia-fragments%2FTC0054.html%2Cmedia%2Fmedia-fragments%2FTC0061.html

e.g.
http://build.webkit.org/results/Apple%20MountainLion%20Debug%20WK2%20(Tests)/r158339%20(13794)/results.html

Comment 1 Ryosuke Niwa 2013-10-30 22:01:57 PDT

Added test expectations in http://trac.webkit.org/changeset/158344.

Comment 2 Eric Carlson 2013-10-31 08:18:04 PDT

0 WTFCrash + 42 (Assertions.cpp:342)
1 WebCore::MediaFragmentURIParser::parseTimeFragment() + 316 (MediaFragmentURIParser.cpp:172)
2 WebCore::MediaFragmentURIParser::startTime() + 74 (MediaFragmentURIParser.cpp:92)

MediaFragmentURIParser.cpp:172 is:

        ASSERT(fragment.second.is8Bit());

This has been in the code since it was checked in almost two years ago. Why is it asserting now?

Comment 3 Ryosuke Niwa 2013-10-31 10:45:37 PDT

Maybe we're not creating a string in 16-bit mode?

Comment 4 Eric Carlson 2013-11-04 16:37:54 PST

Created attachment 215969 [details]
Proposed patch

Comment 5 Ryosuke Niwa 2013-11-04 16:44:08 PST

Could you also removed the test expectation I added in http://trac.webkit.org/changeset/158344 ?

Comment 6 Eric Carlson 2013-11-04 16:52:34 PST

Created attachment 215973 [details]
Updated patch

Comment 7 Eric Carlson 2013-11-04 16:52:54 PST

(In reply to comment #5)
> Could you also removed the test expectation I added in http://trac.webkit.org/changeset/158344 ?

Oops, removed in the updated patch.

Comment 8 Darin Adler 2013-11-04 17:21:03 PST

Comment on attachment 215973 [details]
Updated patch

View in context: https://bugs.webkit.org/attachment.cgi?id=215973&action=review

> Source/WebCore/ChangeLog:12
> +            they will not processed.

not be processed

Comment 9 WebKit Commit Bot 2013-11-04 17:31:19 PST

Comment on attachment 215973 [details]
Updated patch

Clearing flags on attachment: 215973

Committed r158624: <http://trac.webkit.org/changeset/158624>

Comment 10 WebKit Commit Bot 2013-11-04 17:31:21 PST

All reviewed patches have been landed.  Closing bug.