Bug 123554

Summary:

Manage EllipsisBox objects with unique_ptr.

Product:

WebKit

Reporter:

Andreas Kling <kling>

Component:

Layout and Rendering

Assignee:

Andreas Kling <kling>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, esprehn+autocc, glenn, kondapallykalyan

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Andreas Kling 2013-10-30 21:21:57 PDT

It's happening.

Comment 1 Andreas Kling 2013-10-30 21:23:03 PDT

Created attachment 215610 [details]
Patch

Comment 2 Anders Carlsson 2013-10-30 21:24:21 PDT

Comment on attachment 215610 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=215610&action=review

> Source/WebCore/rendering/RootInlineBox.cpp:52
> +typedef WTF::HashMap<const RootInlineBox*, std::unique_ptr<EllipsisBox>> EllipsisBoxMap;

No need for the WTF here.

Comment 3 WebKit Commit Bot 2013-10-30 22:50:05 PDT

Comment on attachment 215610 [details]
Patch

Clearing flags on attachment: 215610

Committed r158346: <http://trac.webkit.org/changeset/158346>

Comment 4 WebKit Commit Bot 2013-10-30 22:50:07 PDT

All reviewed patches have been landed.  Closing bug.