Bug 123554 - Manage EllipsisBox objects with unique_ptr.
Summary: Manage EllipsisBox objects with unique_ptr.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-10-30 21:21 PDT by Andreas Kling
Modified: 2013-10-30 22:50 PDT (History)
4 users (show)

See Also:

Attachments
Patch (2.65 KB, patch)
2013-10-30 21:23 PDT, Andreas Kling 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2013-10-30 21:21:57 PDT 
It's happening.
Comment 1 Andreas Kling 2013-10-30 21:23:03 PDT 
Created attachment 215610 [details]
Patch
Comment 2 Anders Carlsson 2013-10-30 21:24:21 PDT 
Comment on attachment 215610 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=215610&action=review

> Source/WebCore/rendering/RootInlineBox.cpp:52
> +typedef WTF::HashMap<const RootInlineBox*, std::unique_ptr<EllipsisBox>> EllipsisBoxMap;

No need for the WTF here.
Comment 3 WebKit Commit Bot 2013-10-30 22:50:05 PDT 
Comment on attachment 215610 [details]
Patch

Clearing flags on attachment: 215610

Committed r158346: <http://trac.webkit.org/changeset/158346>
Comment 4 WebKit Commit Bot 2013-10-30 22:50:07 PDT 
All reviewed patches have been landed.  Closing bug.